Re: [PATCH v3 5/5] tests: fix and add lint for non-portable grep --file

2018-08-24 Thread Derrick Stolee
On 8/23/2018 4:44 PM, Junio C Hamano wrote: Ævar Arnfjörð Bjarmason writes: The --file option to grep isn't in POSIX[1], but -f is[1]. Let's check for that in the future, and fix the portability regression in f237c8b6fe ("commit-graph: implement git-commit-graph write", 2018-04-02) that

Re: [PATCH v3 5/5] tests: fix and add lint for non-portable grep --file

2018-08-23 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > The --file option to grep isn't in POSIX[1], but -f is[1]. Let's check > for that in the future, and fix the portability regression in > f237c8b6fe ("commit-graph: implement git-commit-graph write", > 2018-04-02) that broke e.g. AIX. > > 1.

[PATCH v3 5/5] tests: fix and add lint for non-portable grep --file

2018-08-23 Thread Ævar Arnfjörð Bjarmason
The --file option to grep isn't in POSIX[1], but -f is[1]. Let's check for that in the future, and fix the portability regression in f237c8b6fe ("commit-graph: implement git-commit-graph write", 2018-04-02) that broke e.g. AIX. 1. http://pubs.opengroup.org/onlinepubs/009695399/utilities/grep.html