Re: [PATCH v4] commit.c: use skip_prefix() instead of starts_with()

2014-03-05 Thread Junio C Hamano
tanay abhra writes: > On Wed, Mar 5, 2014 at 3:41 AM, Junio C Hamano wrote: > >> Junio C Hamano writes: >> >> >> +found = skip_prefix(buf, sigcheck_gpg_status[i].check + 1); >> >> +if(!found) { >> >> Missing SP between the control keyword and parenthesized expression >>

Re: [PATCH v4] commit.c: use skip_prefix() instead of starts_with()

2014-03-04 Thread Tanay Abhra
Junio C Hamano pobox.com> writes: > > Junio C Hamano pobox.com> writes: > > >> + found = skip_prefix(buf, sigcheck_gpg_status[i].check + 1); > >> + if(!found) { > > Missing SP between the control keyword and parenthesized expression > the keyword uses. > > I've fixed this (

Re: [PATCH v4] commit.c: use skip_prefix() instead of starts_with()

2014-03-04 Thread Junio C Hamano
Junio C Hamano writes: >> +found = skip_prefix(buf, sigcheck_gpg_status[i].check + 1); >> +if(!found) { Missing SP between the control keyword and parenthesized expression the keyword uses. I've fixed this (and the broken indentation) locally and queued the result to 'pu

Re: [PATCH v4] commit.c: use skip_prefix() instead of starts_with()

2014-03-04 Thread Junio C Hamano
Tanay Abhra writes: > In record_author_date() & parse_gpg_output(), the callers of > starts_with() not just want to know if the string starts with the > prefix, but also can benefit from knowing the string that follows > the prefix. > > By using skip_prefix(), we can do both at the same time. > >

[PATCH v4] commit.c: use skip_prefix() instead of starts_with()

2014-03-04 Thread Tanay Abhra
In record_author_date() & parse_gpg_output(), the callers of starts_with() not just want to know if the string starts with the prefix, but also can benefit from knowing the string that follows the prefix. By using skip_prefix(), we can do both at the same time. Helped-by: Max Horn Helped-by: Jun