Re: [PATCH v4] git_connect: set ssh shell command in GIT_SSH_COMMAND

2014-11-10 Thread Thomas Quinot
* Jeff King, 2014-11-10 : I think this version looks good. Thanks for working on it. Thanks! Two style micro-nits (that I do not think even merit a re-roll by themselves, but Junio may want to mark up as he applies): OK, committed locally, I can resend a PATCH v5 if that's more convenient

Re: [PATCH v4] git_connect: set ssh shell command in GIT_SSH_COMMAND

2014-11-10 Thread Junio C Hamano
Thomas Quinot tho...@quinot.org writes: * Jeff King, 2014-11-10 : I think this version looks good. Thanks for working on it. Thanks! Two style micro-nits (that I do not think even merit a re-roll by themselves, but Junio may want to mark up as he applies): OK, committed locally, I can

[PATCH v4] git_connect: set ssh shell command in GIT_SSH_COMMAND

2014-11-09 Thread Thomas Quinot
It may be impractical to install a wrapper script for GIT_SSH when additional parameters need to be passed. Provide an alternative way of specifying a shell command to be run, including command line arguments, by means of the GIT_SSH_COMMAND environment variable, which behaves like GIT_SSH but is

Re: [PATCH v4] git_connect: set ssh shell command in GIT_SSH_COMMAND

2014-11-09 Thread Jeff King
On Sun, Nov 09, 2014 at 11:42:32PM +0100, Thomas Quinot wrote: It may be impractical to install a wrapper script for GIT_SSH when additional parameters need to be passed. Provide an alternative way of specifying a shell command to be run, including command line arguments, by means of the