Re: [PATCH v4 00/12] unify appending of sob

2013-02-12 Thread Junio C Hamano
Jonathan Nieder writes: > Brandon Casey wrote: > >> Round 4. > > Yay. I think this is cooked now and a good foundation for later > changes on top. > > For what it's worth, with or without the two tweaks Junio suggested > (simplifying "(cherry picked from" detection, deferring introduction > of n

Re: [PATCH v4 00/12] unify appending of sob

2013-02-12 Thread Jonathan Nieder
Brandon Casey wrote: > Round 4. Yay. I think this is cooked now and a good foundation for later changes on top. For what it's worth, with or without the two tweaks Junio suggested (simplifying "(cherry picked from" detection, deferring introduction of no_dup_sob variable until it is used), Revi

[PATCH v4 00/12] unify appending of sob

2013-02-12 Thread Brandon Casey
Round 4. Interdiff against round 3 follows the diff stat. -Brandon Brandon Casey (9): commit, cherry-pick -s: remove broken support for multiline rfc2822 fields t/test-lib-functions.sh: allow to specify the tag name to test_commit t/t3511: add some tests of 'cherry-pick -s' functionali