Re: [PATCH v4 08/25] sequencer: completely revamp the "todo" script parsing

2016-10-18 Thread Johannes Schindelin
Hi Junio, On Mon, 17 Oct 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > - for (i = 1; *p; i++) { > > + for (i = 1; *p; i++, p = next_p) { > > char *eol = strchrnul(p, '\n'); > > - commit = parse_insn_line(p, eol, opts); > > - if (!commit) > >

Re: [PATCH v4 08/25] sequencer: completely revamp the "todo" script parsing

2016-10-17 Thread Junio C Hamano
Johannes Schindelin writes: > - for (i = 1; *p; i++) { > + for (i = 1; *p; i++, p = next_p) { > char *eol = strchrnul(p, '\n'); > - commit = parse_insn_line(p, eol, opts); > - if (!commit) > - return error(_("Could not parse line %

[PATCH v4 08/25] sequencer: completely revamp the "todo" script parsing

2016-10-14 Thread Johannes Schindelin
When we came up with the "sequencer" idea, we really wanted to have kind of a plumbing equivalent of the interactive rebase. Hence the choice of words: the "todo" script, a "pick", etc. However, when it came time to implement the entire shebang, somehow this idea got lost and the sequencer was use