Re: [PATCH v4 1/6] diff: diff_aligned_abbrev: remove ellipsis after abbreviated SHA-1 value

2017-11-25 Thread Junio C Hamano
Junio C Hamano writes: > - 5/6: What we see in [v4 1/6] (except for introduction of the > helper, which already happened in an earlier step). Move > the promise of covering this new output format with a follow > up series to the proposed log message

Re: [PATCH v4 1/6] diff: diff_aligned_abbrev: remove ellipsis after abbreviated SHA-1 value

2017-11-25 Thread Junio C Hamano
... and this is a sample of the "remainder" of 6/6 outlined in the previous message, to become part of 5/6 to show how the new output would look like in a test form. t/t4013-diff-various.sh| 1 +

Re: [PATCH v4 1/6] diff: diff_aligned_abbrev: remove ellipsis after abbreviated SHA-1 value

2017-11-25 Thread Junio C Hamano
Junio C Hamano writes: > Thanks for sticking with this topic---very much appreciated, as we > saw many newcomers get tired of doing repeated polishing and abandon > their topic in the past. I have to go offline now, but will comment > later when I come back. Regarding the

Re: [PATCH v4 1/6] diff: diff_aligned_abbrev: remove ellipsis after abbreviated SHA-1 value

2017-11-24 Thread Junio C Hamano
Ann T Ropea writes: > Neither Git nor the user are in need of this (visual) aid anymore, but > we must offer a transition period. > > Also, fix a typo: "abbbreviated" ---> "abbreviated". > > Signed-off-by: Ann T Ropea > --- > v2: rename patch series & focus