Re: [PATCH v4 1/6] t9001: non order-sensitive file comparison

On 06/08/2016 06:56 PM, Junio C Hamano wrote: > The earliest address pa...@example.com and later addresses have > quite different meaning (the first one is meant to be the envelope > sender address, and does not name a recipient). While I think it is > a good idea to tell the test that the order

Re: [PATCH v4 1/6] t9001: non order-sensitive file comparison

On 06/08/2016 07:17 PM, Junio C Hamano wrote: Here is an illustration of an organization that I think would be easier to read, and would result in a more readable patch when modification is made on top. The first two hunks collapse the overall "setup" steps that appear as three separate tests

Re: [PATCH v4 1/6] t9001: non order-sensitive file comparison

Samuel GROOT writes: > @@ -97,7 +104,7 @@ test_expect_success $PREREQ 'setup expect' ' > ' > > test_expect_success $PREREQ 'Verify commandline' ' > - test_cmp expected commandline1 > + test_cmp_noorder expected commandline1 > ' > >

Re: [PATCH v4 1/6] t9001: non order-sensitive file comparison

Samuel GROOT writes: > @@ -117,7 +124,7 @@ test_expect_success $PREREQ 'setup expect' ' > ' > > test_expect_success $PREREQ 'Verify commandline' ' > - test_cmp expected commandline1 > + test_cmp_noorder expected commandline1 > ' > >

Re: [PATCH v4 1/6] t9001: non order-sensitive file comparison

On 06/08/2016 04:22 PM, Remi Galan Alfonso wrote: +test_cmp_noorder () { +sort "$1" >"$1_noorder" +sort "$2" >"$2_noorder" +test_cmp $1 $2 You meant `test_cmp "$1_noorder" "$2_noorder"`, I guess. Yes, thanks for pointing it out! -- To unsubscribe from this list: send

Re: [PATCH v4 1/6] t9001: non order-sensitive file comparison

Hi Samuel, Samuel GROOT writes: > +test_cmp_noorder () { > +sort "$1" >"$1_noorder" > +sort "$2" >"$2_noorder" > +test_cmp $1 $2 You meant `test_cmp "$1_noorder" "$2_noorder"`, I guess. Thanks, Rémi -- To unsubscribe from this list: send

[PATCH v4 1/6] t9001: non order-sensitive file comparison

Tests might fail if lines compared in text files don't have the same order. Signed-off-by: Samuel GROOT Signed-off-by: Tom RUSSELLO Signed-off-by: Matthieu MOY --- t/t9001-send-email.sh | 13