Re: [PATCH v4 1/9] submodule: add a print_config_from_gitmodules() helper

2018-09-04 Thread Antonio Ospite
On Fri, 24 Aug 2018 18:52:51 +0200 Antonio Ospite wrote: [...] > I'll wait for other comments to see if a v5 is really needed. > Ping. In case someone missed v4. Thanks, Antonio -- Antonio Ospite https://ao2.it https://twitter.com/ao2it A: Because it messes up the order in which people

Re: [PATCH v4 1/9] submodule: add a print_config_from_gitmodules() helper

2018-08-24 Thread Antonio Ospite
On Fri, 24 Aug 2018 16:32:38 +0200 Ævar Arnfjörð Bjarmason wrote: > > On Fri, Aug 24 2018, Antonio Ospite wrote: [...] > > +static int config_print_callback(const char *key_, const char *value_, > > void *cb_data) > > +{ > > + char *key = cb_data; > > + > > + if (!strcmp(key, key_)) > > +

Re: [PATCH v4 1/9] submodule: add a print_config_from_gitmodules() helper

2018-08-24 Thread Ævar Arnfjörð Bjarmason
On Fri, Aug 24 2018, Antonio Ospite wrote: > Add a new print_config_from_gitmodules() helper function to print values > from .gitmodules just like "git config -f .gitmodules" would. > > This will be used by a new submodule--helper subcommand to be able to > access the .gitmodules file in a more

[PATCH v4 1/9] submodule: add a print_config_from_gitmodules() helper

2018-08-24 Thread Antonio Ospite
Add a new print_config_from_gitmodules() helper function to print values from .gitmodules just like "git config -f .gitmodules" would. This will be used by a new submodule--helper subcommand to be able to access the .gitmodules file in a more controlled way. Signed-off-by: Antonio Ospite ---