Re: [PATCH v4 2/3] Show items of interactive git-clean in columns

2013-05-03 Thread Matthieu Moy
Jiang Xin writes: > Rewrite the log as following: That's probably more than needed ;-). Thanks, > Show items of interactive git-clean in columns > > When there are lots of items to be cleaned, it is hard to see them all > in one screen. Show them in columns instead of in one column will solve >

Re: [PATCH v4 2/3] Show items of interactive git-clean in columns

2013-05-02 Thread Jiang Xin
2013/5/2 Matthieu Moy : > Jiang Xin writes: > >> Signed-off-by: Jiang Xin > > This lacks a proper commit message (why is this a good thing?), and Rewrite the log as following: Show items of interactive git-clean in columns When there are lots of items to be cleaned, it is hard to see them all

Re: [PATCH v4 2/3] Show items of interactive git-clean in columns

2013-05-02 Thread Matthieu Moy
Jiang Xin writes: > Signed-off-by: Jiang Xin This lacks a proper commit message (why is this a good thing?), and documentation (you introduce column.clean) but the code sounds good (that's a very quick look from me, not a "review" sorry). -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To

[PATCH v4 2/3] Show items of interactive git-clean in columns

2013-05-02 Thread Jiang Xin
Signed-off-by: Jiang Xin --- builtin/clean.c | 63 + 1 file changed, 46 insertions(+), 17 deletions(-) diff --git a/builtin/clean.c b/builtin/clean.c index 407744e5..ac48e 100644 --- a/builtin/clean.c +++ b/builtin/clean.c @@ -13,9 +13,11 @