Re: [PATCH v4 3/9] submodule.c: sort changed_submodule_names before searching it

2018-09-26 Thread Junio C Hamano
Stefan Beller writes: > We can string_list_insert() to maintain sorted-ness of the > list as we find new items, or we can string_list_append() to > build an unsorted list and sort it at the end just once. > > To pick which one is more appropriate, we notice the fact > that we discover new items

[PATCH v4 3/9] submodule.c: sort changed_submodule_names before searching it

2018-09-25 Thread Stefan Beller
We can string_list_insert() to maintain sorted-ness of the list as we find new items, or we can string_list_append() to build an unsorted list and sort it at the end just once. To pick which one is more appropriate, we notice the fact that we discover new items more or less in the already sorted