Re: [PATCH v5] worktree: add: introduce --checkout option

2016-03-30 Thread Eric Sunshine
[please don't top-post] On Tue, Mar 29, 2016 at 11:11 PM, Zhang Lei wrote: > Thanks for the review. > Sorry for the patch churn, I wasn't quite familiar with working with > mailing list. No need to apologize. Reviewers understand what it is like being a newcomer and provide additional review com

Re: [PATCH v5] worktree: add: introduce --checkout option

2016-03-29 Thread Zhang Lei
Thanks for the review. Sorry for the patch churn, I wasn't quite familiar with working with mailing list. 2016-03-30 3:20 GMT+08:00 Eric Sunshine : > On Tue, Mar 29, 2016 at 6:11 AM, Ray Zhang wrote: >> By adding this option which defaults to true, we can use the >> corresponding --no-checkout to

Re: [PATCH v5] worktree: add: introduce --checkout option

2016-03-29 Thread Junio C Hamano
John Keeping writes: > Having gone looking, I can't find a reference but I for some reason I > was convinced the separate version was preferred in the option > descriptions. The one that is similar that came back to my mind while reading your response was that we used to have these: --

Re: [PATCH v5] worktree: add: introduce --checkout option

2016-03-29 Thread John Keeping
On Tue, Mar 29, 2016 at 02:04:38PM -0400, Eric Sunshine wrote: > On Tue, Mar 29, 2016 at 6:54 AM, John Keeping wrote: > > On Tue, Mar 29, 2016 at 10:11:01AM +, Ray Zhang wrote: > >> With `add`, detach HEAD in the new working tree. See "DETACHED HEAD" > >> in linkgit:git-checkout[1]

Re: [PATCH v5] worktree: add: introduce --checkout option

2016-03-29 Thread Eric Sunshine
On Tue, Mar 29, 2016 at 6:11 AM, Ray Zhang wrote: > By adding this option which defaults to true, we can use the > corresponding --no-checkout to make some customizations before > the checkout, like sparse checkout, etc. > > Reviewed-by: Eric Sunshine > Signed-off-by: Ray Zhang > --- > Changes s

Re: [PATCH v5] worktree: add: introduce --checkout option

2016-03-29 Thread Eric Sunshine
On Tue, Mar 29, 2016 at 6:54 AM, John Keeping wrote: > On Tue, Mar 29, 2016 at 10:11:01AM +, Ray Zhang wrote: >> With `add`, detach HEAD in the new working tree. See "DETACHED HEAD" >> in linkgit:git-checkout[1]. >> >> +--[no-]checkout:: > > This should be: > > --checkout:: > --no-

Re: [PATCH v5] worktree: add: introduce --checkout option

2016-03-29 Thread John Keeping
On Tue, Mar 29, 2016 at 10:11:01AM +, Ray Zhang wrote: > By adding this option which defaults to true, we can use the > corresponding --no-checkout to make some customizations before > the checkout, like sparse checkout, etc. > > Helped-by: Eric Sunshine > Helped-by: Junio C Hamano > Reviewe

[PATCH v5] worktree: add: introduce --checkout option

2016-03-29 Thread Ray Zhang
By adding this option which defaults to true, we can use the corresponding --no-checkout to make some customizations before the checkout, like sparse checkout, etc. Helped-by: Eric Sunshine Helped-by: Junio C Hamano Reviewed-by: Eric Sunshine Signed-off-by: Ray Zhang --- Changes since last ver