Re: [PATCH v5 0/4] unpack_trees_options: free messages when done

Martin Ågren writes: > (Maybe not to fix the leaking as such, but to keep 'maint' more up to > date with 'master' for easier merging of other topics?) I admit that I occasionally do such a "presumably no-op" merge to 'maint' out of sheer laziness, but in general I'd

Re: [PATCH v5 0/4] unpack_trees_options: free messages when done

On 22 May 2018 at 04:54, Junio C Hamano wrote: > Junio C Hamano writes: >> Hmph, this unfortunately depends on 'next', which means we cannot >> merge it down to 'maint' later to fix these leaks. I guess it is >> not a huge deal, though. We've lived with

Re: [PATCH v5 0/4] unpack_trees_options: free messages when done

Junio C Hamano writes: > Martin Ågren writes: > >> I've taken the six patches that Junio has queued and rebuilt the series >> to get rid of the new and possibly bug-prone function that no-one uses >> once the series is over. > > Hmph, this

Re: [PATCH v5 0/4] unpack_trees_options: free messages when done

Martin Ågren writes: > I've taken the six patches that Junio has queued and rebuilt the series > to get rid of the new and possibly bug-prone function that no-one uses > once the series is over. Hmph, this unfortunately depends on 'next', which means we cannot merge it

Re: [PATCH v5 0/4] unpack_trees_options: free messages when done

On Mon, May 21, 2018 at 04:54:24PM +0200, Martin Ågren wrote: > That is, I've replaced the `string_list_appendf()`-patch with Junio's > `argv_push*()`-patch, then squashed Junio's "redoing the 4/4"-patch into > patch 4/4 -- with the exception of keeping the `memset(opts->msgs, ...)` > which I

[PATCH v5 0/4] unpack_trees_options: free messages when done

On 21 May 2018 at 02:25, Junio C Hamano wrote: > Junio C Hamano writes: > >> I have a feeling that argv_array might be a better fit for the >> purpose of keeping track of to_free[] strings in the context of this >> series. Moving away from string_list would