Re: [PATCH v5 03/15] pkt-line: add `gentle` parameter to format_packet()

2016-08-10 Thread Lars Schneider
> On 10 Aug 2016, at 15:37, Jeff King wrote: > > On Wed, Aug 10, 2016 at 03:29:26PM +0200, Lars Schneider wrote: > >> >>> On 10 Aug 2016, at 15:15, Jeff King wrote: >>> >>> On Wed, Aug 10, 2016 at 03:03:59PM +0200, larsxschnei...@gmail.com wrote: >>>

[PATCH v5 03/15] pkt-line: add `gentle` parameter to format_packet()

2016-08-10 Thread larsxschneider
From: Lars Schneider format_packet() dies if the caller wants to format a packet larger than LARGE_PACKET_MAX. Certain callers might prefer an error response instead. Add a parameter `gentle` to define if the function should signal an error with the return value

Re: [PATCH v5 03/15] pkt-line: add `gentle` parameter to format_packet()

2016-08-10 Thread Lars Schneider
> On 10 Aug 2016, at 15:15, Jeff King wrote: > > On Wed, Aug 10, 2016 at 03:03:59PM +0200, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider >> >> format_packet() dies if the caller wants to format a packet larger than >> LARGE_PACKET_MAX.

Re: [PATCH v5 03/15] pkt-line: add `gentle` parameter to format_packet()

2016-08-10 Thread Jeff King
On Wed, Aug 10, 2016 at 03:29:26PM +0200, Lars Schneider wrote: > > > On 10 Aug 2016, at 15:15, Jeff King wrote: > > > > On Wed, Aug 10, 2016 at 03:03:59PM +0200, larsxschnei...@gmail.com wrote: > > > >> From: Lars Schneider > >> > >> format_packet()

Re: [PATCH v5 03/15] pkt-line: add `gentle` parameter to format_packet()

2016-08-10 Thread Jeff King
On Wed, Aug 10, 2016 at 03:03:59PM +0200, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > format_packet() dies if the caller wants to format a packet larger than > LARGE_PACKET_MAX. Certain callers might prefer an error response instead. I am not sure I

Re: [PATCH v5 03/15] pkt-line: add `gentle` parameter to format_packet()

2016-08-10 Thread Jeff King
On Wed, Aug 10, 2016 at 03:59:19PM +0200, Lars Schneider wrote: > > It does still feel a little weird that you cannot tell the difference > > between a write() error and bad input. Because you really might want to > > do something different between the two. Like: > > > > #define MAX_FILENAME