Re: [PATCH v5 1/3] completion: add new __gitcompadd helper

2012-10-30 Thread SZEDER Gábor
On Mon, Oct 22, 2012 at 02:41:21AM +0200, Felipe Contreras wrote: > On Wed, Oct 17, 2012 at 7:28 PM, SZEDER Gábor wrote: > > On Sun, Oct 14, 2012 at 05:52:49PM +0200, Felipe Contreras wrote: > > >> diff --git a/contrib/completion/git-completion.bash > >> b/contrib/completion/git-completion.bash

Re: [PATCH v5 1/3] completion: add new __gitcompadd helper

2012-10-21 Thread Felipe Contreras
On Wed, Oct 17, 2012 at 7:28 PM, SZEDER Gábor wrote: > On Sun, Oct 14, 2012 at 05:52:49PM +0200, Felipe Contreras wrote: >> diff --git a/contrib/completion/git-completion.bash >> b/contrib/completion/git-completion.bash >> index d743e56..01325de 100644 >> --- a/contrib/completion/git-completion.

Re: [PATCH v5 1/3] completion: add new __gitcompadd helper

2012-10-17 Thread SZEDER Gábor
On Sun, Oct 14, 2012 at 05:52:49PM +0200, Felipe Contreras wrote: > The idea is to never touch the COMPREPLY variable directly. > > This allows other completion systems override __gitcompadd, and do > something different instead. > > Also, this allows the simplifcation of the completino tests (se

[PATCH v5 1/3] completion: add new __gitcompadd helper

2012-10-14 Thread Felipe Contreras
The idea is to never touch the COMPREPLY variable directly. This allows other completion systems override __gitcompadd, and do something different instead. Also, this allows the simplifcation of the completino tests (separate patch). There should be no functional changes. Signed-off-by: Felipe