Re: [PATCH v5 10/14] trailer: execute command from 'trailer.name.command'

2014-02-07 Thread Junio C Hamano
Christian Couder chrisc...@tuxfamily.org writes: Signed-off-by: Christian Couder chrisc...@tuxfamily.org execute command from ... is fine, but I wish there were more details before S-o-b line. Is is not worth explaining what happens to the output, and what the facility is used for in general?

[PATCH v5 10/14] trailer: execute command from 'trailer.name.command'

2014-02-06 Thread Christian Couder
Signed-off-by: Christian Couder chrisc...@tuxfamily.org --- trailer.c | 63 +++ 1 file changed, 63 insertions(+) diff --git a/trailer.c b/trailer.c index 108e104..98187fc 100644 --- a/trailer.c +++ b/trailer.c @@ -1,4 +1,5 @@ #include

Re: [PATCH v5 10/14] trailer: execute command from 'trailer.name.command'

2014-02-06 Thread Junio C Hamano
Christian Couder chrisc...@tuxfamily.org writes: +#define TRAILER_ARG_STRING $ARG No need to support users who may want to use a string that happens to match this substring literally as part of the command line? struct trailer_item { struct trailer_item *previous; struct