Re: [PATCH v5 4/5] config: improve support for http.url.* settings

2013-07-16 Thread Kyle J. McKay
On Jul 15, 2013, at 16:12, Eric Sunshine wrote: On Mon, Jul 15, 2013 at 5:51 AM, Kyle J. McKay mack...@gmail.com wrote: +static int append_normalized_escapes(struct strbuf *buf, +const char *from, +size_t from_len, +

Re: [PATCH v5 4/5] config: improve support for http.url.* settings

2013-07-16 Thread Eric Sunshine
On Tue, Jul 16, 2013 at 5:53 AM, Kyle J. McKay mack...@gmail.com wrote: On Jul 15, 2013, at 16:12, Eric Sunshine wrote: On Mon, Jul 15, 2013 at 5:51 AM, Kyle J. McKay mack...@gmail.com wrote: +static int append_normalized_escapes(struct strbuf *buf, +const

[PATCH v5 4/5] config: improve support for http.url.* settings

2013-07-15 Thread Kyle J. McKay
Improve on the http.url.* url matching behavior by first normalizing the urls before they are compared. With this change, for example, the following configuration section: [http https://example.com/path;] useragent = example-agent sslVerify = false will properly match a

Re: [PATCH v5 4/5] config: improve support for http.url.* settings

2013-07-15 Thread Eric Sunshine
On Mon, Jul 15, 2013 at 5:51 AM, Kyle J. McKay mack...@gmail.com wrote: Improve on the http.url.* url matching behavior by first normalizing the urls before they are compared. diff --git a/http.c b/http.c index 758e5b1..d04386e 100644 --- a/http.c +++ b/http.c @@ -169,6 +169,210 @@ static