Re: [PATCH v5 4/6] list-objects: filter objects in traverse_commit_list

2017-11-30 Thread Jeff King
On Mon, Nov 27, 2017 at 02:39:43PM -0500, Jeff Hostetler wrote: > On 11/22/2017 5:56 PM, Stefan Beller wrote: > > On Tue, Nov 21, 2017 at 12:58 PM, Jeff Hostetler > > wrote: > > > + assert(arg); > > > + assert(!unset); > > > > I count 16 asserts in this

Re: [PATCH v5 4/6] list-objects: filter objects in traverse_commit_list

2017-11-27 Thread Jeff Hostetler
On 11/22/2017 5:56 PM, Stefan Beller wrote: On Tue, Nov 21, 2017 at 12:58 PM, Jeff Hostetler wrote: + assert(arg); + assert(!unset); I count 16 asserts in this patch. Is that really needed? Either omit them or use BUG if we want to rely on user bug

Re: [PATCH v5 4/6] list-objects: filter objects in traverse_commit_list

2017-11-22 Thread Stefan Beller
On Tue, Nov 21, 2017 at 12:58 PM, Jeff Hostetler wrote: > + assert(arg); > + assert(!unset); I count 16 asserts in this patch. Is that really needed? Either omit them or use BUG if we want to rely on user bug reports when these conditions trigger, as assert is

[PATCH v5 4/6] list-objects: filter objects in traverse_commit_list

2017-11-21 Thread Jeff Hostetler
From: Jeff Hostetler Create traverse_commit_list_filtered() and add filtering interface to allow certain objects to be omitted from the traversal. Update traverse_commit_list() to be a wrapper for the above with a null filter to minimize the number of callers that needed