Re: [PATCH v6 13/13] read-cache: make sure file handles are not inherited by child processes

Torsten Bögershausen writes: >> >> diff --git a/sha1_file.c b/sha1_file.c >> index d5e1121..759991e 100644 >> --- a/sha1_file.c >> +++ b/sha1_file.c >> @@ -1485,7 +1485,7 @@ int check_sha1_signature(const unsigned char *sha1, >> void *map, >> >> int git_open_noatime(const

Re: [PATCH v6 13/13] read-cache: make sure file handles are not inherited by child processes

> > diff --git a/sha1_file.c b/sha1_file.c > index d5e1121..759991e 100644 > --- a/sha1_file.c > +++ b/sha1_file.c > @@ -1485,7 +1485,7 @@ int check_sha1_signature(const unsigned char *sha1, > void *map, > > int git_open_noatime(const char *name) Hm, should the function then be renamed into

Re: [PATCH v6 13/13] read-cache: make sure file handles are not inherited by child processes

> On 29 Aug 2016, at 21:45, Junio C Hamano wrote: > > Lars Schneider writes: > >> I see. Thanks for the explanation. > > I expect the updated log message to explain the issue correctly > then. Sure! >>> The parent is >>> very likely to have

Re: [PATCH v6 13/13] read-cache: make sure file handles are not inherited by child processes

Lars Schneider writes: > I see. Thanks for the explanation. I expect the updated log message to explain the issue correctly then. >> And even on POSIX systems, if you are doing a long-running helper >> any open file descriptor in the parent process when the

Re: [PATCH v6 13/13] read-cache: make sure file handles are not inherited by child processes

> On 29 Aug 2016, at 20:05, Junio C Hamano wrote: > > larsxschnei...@gmail.com writes: > >> From: Lars Schneider >> >> Consider the case of a file that requires filtering and is present in >> branch A but not in branch B. If A is the current HEAD

Re: [PATCH v6 13/13] read-cache: make sure file handles are not inherited by child processes

larsxschnei...@gmail.com writes: > From: Lars Schneider > > Consider the case of a file that requires filtering and is present in > branch A but not in branch B. If A is the current HEAD and we checkout B > then the following happens: > > 1. ce_compare_data() opens the

[PATCH v6 13/13] read-cache: make sure file handles are not inherited by child processes

From: Lars Schneider Consider the case of a file that requires filtering and is present in branch A but not in branch B. If A is the current HEAD and we checkout B then the following happens: 1. ce_compare_data() opens the file 2. index_fd() detects that the file