[PATCH v6 2/4] config: improve support for http.url.* settings

2013-07-19 Thread Kyle J. McKay
Improve on the http.url.* url matching behavior by first normalizing the urls before they are compared. With this change, for example, the following configuration section: [http https://example.com/path;] useragent = example-agent sslVerify = false will properly match a

Re: [PATCH v6 2/4] config: improve support for http.url.* settings

2013-07-19 Thread Junio C Hamano
Kyle J. McKay mack...@gmail.com writes: +#define URL_ALPHA ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz +#define URL_DIGIT 0123456789 +#define URL_HEXDIGIT URL_DIGIT ABCDEFabcdef +#define URL_ALPHADIGIT URL_ALPHA URL_DIGIT +#define URL_SCHEME_CHARS URL_ALPHADIGIT +.- +#define

Re: [PATCH v6 2/4] config: improve support for http.url.* settings

2013-07-19 Thread Kyle J. McKay
On Jul 19, 2013, at 12:59, Junio C Hamano wrote: Kyle J. McKay mack...@gmail.com writes: +#define URL_ALPHA ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz +#define URL_DIGIT 0123456789 +#define URL_HEXDIGIT URL_DIGIT ABCDEFabcdef +#define URL_ALPHADIGIT URL_ALPHA URL_DIGIT +#define

Re: [PATCH v6 2/4] config: improve support for http.url.* settings

2013-07-19 Thread Junio C Hamano
Kyle J. McKay mack...@gmail.com writes: If you mean for all the strchr etc. calls, multiple tables would be required since URL_SCHEME_CHARS and URL_HOST_CHARS partially overlap, The entries of the table could be at least 8-bit wide, so there shouldn't be any problem, should there? but it