RE: [PATCH v6 2/8] read-cache: teach make_cache_entry to take object_id

2018-07-05 Thread Jameson Miller
> > > > Teach make_cache_entry function to take object_id instead of a SHA-1. > > This repeats the subject line? > > Sign off missing. Thank you Stefan for pointing this out. This does not add much information to the subject line. I could clean it up if I re-roll to fix up the missing sign off

Re: [PATCH v6 2/8] read-cache: teach make_cache_entry to take object_id

2018-07-02 Thread Stefan Beller
On Mon, Jul 2, 2018 at 12:49 PM Jameson Miller wrote: > > Teach make_cache_entry function to take object_id instead of a SHA-1. This repeats the subject line? Sign off missing.

[PATCH v6 2/8] read-cache: teach make_cache_entry to take object_id

2018-07-02 Thread Jameson Miller
Teach make_cache_entry function to take object_id instead of a SHA-1. --- apply.c| 2 +- builtin/checkout.c | 2 +- builtin/difftool.c | 4 ++-- builtin/reset.c| 2 +- cache.h| 7 ++- merge-recursive.c | 2 +- read-cache.c | 8 +--- resolve-undo.c | 2