Re: [PATCH v6 5/6] grep: enable recurse-submodules to work on objects

2016-12-01 Thread Jeff King
On Thu, Dec 01, 2016 at 09:51:07AM -0800, Brandon Williams wrote: > On 12/01, Johannes Sixt wrote: > > Am 01.12.2016 um 02:28 schrieb Brandon Williams: > > >+ git init "su:b" && > > > > Don't do that. Colons in file names won't work on Windows. > > > > -- Hannes > > > > This test is needed

Re: [PATCH v6 5/6] grep: enable recurse-submodules to work on objects

2016-12-01 Thread Junio C Hamano
Brandon Williams writes: > On 12/01, Johannes Sixt wrote: >> Am 01.12.2016 um 02:28 schrieb Brandon Williams: >> >+ git init "su:b" && >> >> Don't do that. Colons in file names won't work on Windows. >> >> -- Hannes >> > > This test is needed to see if the code still

Re: [PATCH v6 5/6] grep: enable recurse-submodules to work on objects

2016-12-01 Thread Brandon Williams
On 12/01, Johannes Sixt wrote: > Am 01.12.2016 um 02:28 schrieb Brandon Williams: > >+git init "su:b" && > > Don't do that. Colons in file names won't work on Windows. > > -- Hannes > This test is needed to see if the code still works with filenames that contain colons. Is there a way to

Re: [PATCH v6 5/6] grep: enable recurse-submodules to work on objects

2016-11-30 Thread Johannes Sixt
Am 01.12.2016 um 02:28 schrieb Brandon Williams: + git init "su:b" && Don't do that. Colons in file names won't work on Windows. -- Hannes

[PATCH v6 5/6] grep: enable recurse-submodules to work on objects

2016-11-30 Thread Brandon Williams
Teach grep to recursively search in submodules when provided with a object. This allows grep to search a submodule based on the state of the submodule that is present in a commit of the super project. When grep is provided with a object, the name of the object is prefixed to all output. In