Re: [PATCH v7] read-cache: force_verify_index_checksum

2017-05-08 Thread Junio C Hamano
Christian Couder writes: > On Fri, Apr 14, 2017 at 10:32 PM, wrote: >> diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh >> index 33a51c9..677e15a 100755 >> --- a/t/t1450-fsck.sh >> +++ b/t/t1450-fsck.sh >> @@ -689,4 +689,17 @@

Re: [PATCH v7] read-cache: force_verify_index_checksum

2017-05-08 Thread Junio C Hamano
Jeff Hostetler writes: > On 5/8/2017 4:03 PM, Christian Couder wrote: >> On Mon, May 8, 2017 at 6:50 PM, Jeff Hostetler >> wrote: >>> >>> >>> On 5/8/2017 5:45 AM, Christian Couder wrote: This test does not pass when the

Re: [PATCH v7] read-cache: force_verify_index_checksum

2017-05-08 Thread Jeff Hostetler
On 5/8/2017 4:03 PM, Christian Couder wrote: On Mon, May 8, 2017 at 6:50 PM, Jeff Hostetler wrote: On 5/8/2017 5:45 AM, Christian Couder wrote: This test does not pass when the GIT_TEST_SPLIT_INDEX env variable is set on my Linux machine. Also it looks like you

Re: [PATCH v7] read-cache: force_verify_index_checksum

2017-05-08 Thread Christian Couder
On Mon, May 8, 2017 at 6:50 PM, Jeff Hostetler wrote: > > > On 5/8/2017 5:45 AM, Christian Couder wrote: >> >> This test does not pass when the GIT_TEST_SPLIT_INDEX env variable is >> set on my Linux machine. >> >> Also it looks like you sent a v8 of this patch series with

Re: [PATCH v7] read-cache: force_verify_index_checksum

2017-05-08 Thread Jeff Hostetler
On 5/8/2017 5:45 AM, Christian Couder wrote: On Fri, Apr 14, 2017 at 10:32 PM, wrote: diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh index 33a51c9..677e15a 100755 --- a/t/t1450-fsck.sh +++ b/t/t1450-fsck.sh @@ -689,4 +689,17 @@ test_expect_success 'bogus head does

Re: [PATCH v7] read-cache: force_verify_index_checksum

2017-05-08 Thread Christian Couder
On Fri, Apr 14, 2017 at 10:32 PM, wrote: > diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh > index 33a51c9..677e15a 100755 > --- a/t/t1450-fsck.sh > +++ b/t/t1450-fsck.sh > @@ -689,4 +689,17 @@ test_expect_success 'bogus head does not fallback to all > heads' ' >

Re: [PATCH v7] read-cache: force_verify_index_checksum

2017-04-25 Thread Junio C Hamano
Johannes Schindelin writes: > Just in case that certain reviewers favor length over readability, let me > offer this snippet: > > size=$(perl -e "print -s \".git/index\"") && > dd if=/dev/zero of=.git/index bs=1 seek=$(($size-20) count=20 Yup, this does

Re: [PATCH v7] read-cache: force_verify_index_checksum

2017-04-25 Thread Johannes Schindelin
Hi, On Mon, 24 Apr 2017, Junio C Hamano wrote: > Jeff Hostetler writes: > > >>> +test_expect_success 'detect corrupt index file in fsck' ' > >>> +cp .git/index .git/index.backup && > >>> +test_when_finished "mv .git/index.backup .git/index" && > >>> +echo

Re: [PATCH v7] read-cache: force_verify_index_checksum

2017-04-24 Thread Junio C Hamano
Jeff Hostetler writes: >>> +test_expect_success 'detect corrupt index file in fsck' ' >>> +cp .git/index .git/index.backup && >>> +test_when_finished "mv .git/index.backup .git/index" && >>> +echo > && >>> +git add && >>> +sed

Re: [PATCH v7] read-cache: force_verify_index_checksum

2017-04-24 Thread Jeff Hostetler
On 4/24/2017 1:26 PM, Johannes Sixt wrote: Am 14.04.2017 um 22:32 schrieb g...@jeffhostetler.com: diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh index 33a51c9..677e15a 100755 --- a/t/t1450-fsck.sh +++ b/t/t1450-fsck.sh @@ -689,4 +689,17 @@ test_expect_success 'bogus head does not fallback to

Re: [PATCH v7] read-cache: force_verify_index_checksum

2017-04-24 Thread Johannes Sixt
Am 14.04.2017 um 22:32 schrieb g...@jeffhostetler.com: diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh index 33a51c9..677e15a 100755 --- a/t/t1450-fsck.sh +++ b/t/t1450-fsck.sh @@ -689,4 +689,17 @@ test_expect_success 'bogus head does not fallback to all heads' ' ! grep $blob out '

[PATCH v7] read-cache: force_verify_index_checksum

2017-04-14 Thread git
From: Jeff Hostetler Teach git to skip verification of the SHA1-1 checksum at the end of the index file in verify_hdr() which is called from read_index() unless the "force_verify_index_checksum" global variable is set. Teach fsck to force this verification. The checksum