Re: [PATCH v7 0/3] Incremental rewrite of git-submodules

[Eric Sunshine]

On Sat, Oct 7, 2017 at 4:51 AM, Junio C Hamano  wrote:
> FWIW, the previous one is at
> https://public-inbox.org/git/20170929094453.4499-1-pc44...@gmail.com
> Hope that helps ;-)

Thanks, it does help.

Having scanned discussions of previous versions, I see that some of my
comments do indeed overlap (and sometimes are at odds) with comments
from other reviewers.

Re: [PATCH v7 0/3] Incremental rewrite of git-submodules

[Junio C Hamano]

Prathamesh Chavan  writes:

> Changes in v7:

FWIW, the previous one is at

https://public-inbox.org/git/20170929094453.4499-1-pc44...@gmail.com

Alternatively, the References link can be followed back from the
cover letter to go back to quite an early iteration of the series.

Hope that helps ;-)

[PATCH v7 0/3] Incremental rewrite of git-submodules

[Prathamesh Chavan]

Changes in v7:

* Instead of using cb_flags in the callback data's struct, 'flags' is used.

* Similar changes were applied to the CB_OPT_QUIET and other bits.

* The function compute_rev_name() was formatted in accordance with the "make
  style", into a compact version.

* Call to precompose_argv() in the function status_submodule() was dropped
  as the call was unnecessary.

As before you can find this series at: 
https://github.com/pratham-pc/git/commits/patch-series-1

And its build report is available at: 
https://travis-ci.org/pratham-pc/git/builds/
Branch: patch-series-1
Build #190

The above changes were based on master branch.

Another branch, similar to the above, was created, but was based
on the 'next' branch.
Complete build report of that is also available at:
https://travis-ci.org/pratham-pc/git/builds
Branch: patch-series-1-next
Build #189
The above changes are also push on github and are available at:
https://github.com/pratham-pc/git/commits/patch-series-1-next

Prathamesh Chavan (3):
  submodule--helper: introduce get_submodule_displaypath()
  submodule--helper: introduce for_each_listed_submodule()
  submodule: port submodule subcommand 'status' from shell to C

 builtin/submodule--helper.c | 273 +---
 git-submodule.sh|  61 +-
 2 files changed, 257 insertions(+), 77 deletions(-)

-- 
2.14.2