Re: [PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port

2016-05-25 Thread Torsten Bögershausen
On 05/26/2016 01:34 AM, Mike Hommey wrote: On Tue, May 24, 2016 at 06:44:26AM +0200, Torsten Bögershausen wrote: On 05/23/2016 11:30 PM, Junio C Hamano wrote: Torsten Bögershausen writes: get_host_and_port(_host, ); + /*

Re: [PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port

2016-05-25 Thread Mike Hommey
On Tue, May 24, 2016 at 06:44:26AM +0200, Torsten Bögershausen wrote: > On 05/23/2016 11:30 PM, Junio C Hamano wrote: > > Torsten Bögershausen writes: > > > > > > > > get_host_and_port(_host, ); > > > > > >+/* get_host_and_port may

Re: [PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port

2016-05-23 Thread Torsten Bögershausen
On 05/23/2016 11:30 PM, Junio C Hamano wrote: Torsten Bögershausen writes: get_host_and_port(_host, ); +/* get_host_and_port may not return a port even when +* there is one: In the [host:port]:path case, +

Re: [PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port

2016-05-23 Thread Mike Hommey
On Mon, May 23, 2016 at 02:30:57PM -0700, Junio C Hamano wrote: > Torsten Bögershausen writes: > > get_host_and_port(_host, ); > + /* get_host_and_port may not return a port > even when > +

Re: [PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port

2016-05-23 Thread Junio C Hamano
Torsten Bögershausen writes: get_host_and_port(_host, ); +/* get_host_and_port may not return a port even when + * there is one: In the [host:port]:path case, + *

Re: [PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port

2016-05-22 Thread Torsten Bögershausen
On 05/22/2016 10:03 AM, Mike Hommey wrote: On Sun, May 22, 2016 at 08:07:05AM +0200, Torsten Bögershausen wrote: On 22.05.16 01:17, Mike Hommey wrote: Signed-off-by: Mike Hommey --- connect.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/connect.c b/connect.c

Re: [PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port

2016-05-22 Thread Mike Hommey
On Sun, May 22, 2016 at 08:07:05AM +0200, Torsten Bögershausen wrote: > On 22.05.16 01:17, Mike Hommey wrote: > > Signed-off-by: Mike Hommey > > --- > > connect.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/connect.c b/connect.c > > index

Re: [PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port

2016-05-22 Thread Torsten Bögershausen
On 22.05.16 01:17, Mike Hommey wrote: > Signed-off-by: Mike Hommey > --- > connect.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/connect.c b/connect.c > index c53f3f1..caa2a3c 100644 > --- a/connect.c > +++ b/connect.c > @@ -742,6 +742,12 @@ struct

Re: [PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port

2016-05-21 Thread Eric Sunshine
On Sat, May 21, 2016 at 7:17 PM, Mike Hommey wrote: > Signed-off-by: Mike Hommey > --- > diff --git a/connect.c b/connect.c > @@ -742,6 +742,12 @@ struct child_process *git_connect(int fd[2], const char > *url, >

[PATCH v7 1/9] connect: document why we sometimes call get_port after get_host_and_port

2016-05-21 Thread Mike Hommey
Signed-off-by: Mike Hommey --- connect.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/connect.c b/connect.c index c53f3f1..caa2a3c 100644 --- a/connect.c +++ b/connect.c @@ -742,6 +742,12 @@ struct child_process *git_connect(int fd[2], const char *url,