Re: [PATCH v8 04/44] refs.c: add an err argument to repack_without_refs

2014-05-15 Thread Ronnie Sahlberg
On Thu, May 15, 2014 at 11:38 AM, Jonathan Nieder wrote: > Ronnie Sahlberg wrote: >> --- a/refs.c >> +++ b/refs.c >> @@ -2427,12 +2427,12 @@ static int curate_packed_ref_fn(struct ref_entry >> *entry, void *cb_data) >> return 0; >> } >> >> -static int repack_without_refs(const char **refna

Re: [PATCH v8 04/44] refs.c: add an err argument to repack_without_refs

2014-05-15 Thread Jonathan Nieder
Ronnie Sahlberg wrote: > --- a/refs.c > +++ b/refs.c > @@ -2427,12 +2427,12 @@ static int curate_packed_ref_fn(struct ref_entry > *entry, void *cb_data) > return 0; > } > > -static int repack_without_refs(const char **refnames, int n) > +static int repack_without_refs(const char **refname

[PATCH v8 04/44] refs.c: add an err argument to repack_without_refs

2014-05-15 Thread Ronnie Sahlberg
Update repack_without_refs to take an err argument and update it if there is a failure. Pass the err variable from ref_transaction_commit to this function so that callers can print a meaningful error message if _commit fails due to a problem in repack_without_refs. Signed-off-by: Ronnie Sahlberg