Re: [PATCH v8 11/11] convert: add filter..process option

2016-10-06 Thread Lars Schneider
> On 04 Oct 2016, at 23:00, Jakub Narębski wrote: > > [Some of answers and comments may got invalidated by v9] > > W dniu 30.09.2016 o 21:38, Lars Schneider pisze: >>> On 27 Sep 2016, at 17:37, Jakub Narębski wrote: >>> >>> Part second of the review of

Re: [PATCH v8 11/11] convert: add filter..process option

2016-10-06 Thread Lars Schneider
> On 04 Oct 2016, at 22:50, Jakub Narębski wrote: > > [Some of answers may get invalidated by v9] > > W dniu 30.09.2016 o 20:56, Lars Schneider pisze: >>> On 27 Sep 2016, at 00:41, Jakub Narębski wrote: >>> + +After the filter has processed a

Re: [PATCH v8 11/11] convert: add filter..process option

2016-10-04 Thread Jakub Narębski
[Some of answers and comments may got invalidated by v9] W dniu 01.10.2016 o 17:34, Lars Schneider pisze: >> On 29 Sep 2016, at 01:14, Jakub Narębski wrote: >> >> Part third (and last) of the review of v8 11/11. [...] >>> + >>> +test_expect_success PERL 'required process

Re: [PATCH v8 11/11] convert: add filter..process option

2016-10-04 Thread Jakub Narębski
[Some of answers and comments may got invalidated by v9] W dniu 30.09.2016 o 21:38, Lars Schneider pisze: >> On 27 Sep 2016, at 17:37, Jakub Narębski wrote: >> >> Part second of the review of 11/11. [...] >>> + >>> + if (start_command(process)) { >>> + error("cannot

Re: [PATCH v8 11/11] convert: add filter..process option

2016-10-04 Thread Jakub Narębski
[Some of answers may get invalidated by v9] W dniu 30.09.2016 o 20:56, Lars Schneider pisze: >> On 27 Sep 2016, at 00:41, Jakub Narębski wrote: >> >> Part first of the review of 11/11. [...] >>> +to read a welcome response message ("git-filter-server") and exactly >>> +one

Re: [PATCH v8 11/11] convert: add filter..process option

2016-10-01 Thread Lars Schneider
> On 29 Sep 2016, at 01:14, Jakub Narębski wrote: > > Part third (and last) of the review of v8 11/11. > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com napisał: > > >> @@ -31,7 +31,10 @@ test_expect_success setup ' >> cat test >test.i && >> git add test

Re: [PATCH v8 11/11] convert: add filter..process option

2016-09-30 Thread Lars Schneider
> On 27 Sep 2016, at 17:37, Jakub Narębski wrote: > > Part second of the review of 11/11. > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: > >> + >> +if (!drv->process && (CAP_CLEAN & wanted_capability) && drv->clean) > > This is just a very minor

Re: [PATCH v8 11/11] convert: add filter..process option

2016-09-30 Thread Lars Schneider
> On 27 Sep 2016, at 00:41, Jakub Narębski wrote: > > Part first of the review of 11/11. > > W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: >> From: Lars Schneider >> >> diff --git a/Documentation/gitattributes.txt >>

Re: [PATCH v8 11/11] convert: add filter..process option

2016-09-28 Thread Jakub Narębski
Part third (and last) of the review of v8 11/11. W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com napisał: [...] > diff --git a/contrib/long-running-filter/example.pl > b/contrib/long-running-filter/example.pl > new file mode 100755 > index 000..c13a631 > --- /dev/null > +++

Re: [PATCH v8 11/11] convert: add filter..process option

2016-09-27 Thread Jakub Narębski
Part second of the review of 11/11. W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: > diff --git a/contrib/long-running-filter/example.pl > b/contrib/long-running-filter/example.pl > new file mode 100755 > index 000..c13a631 > --- /dev/null > +++

Re: [PATCH v8 11/11] convert: add filter..process option

2016-09-26 Thread Jakub Narębski
Part first of the review of 11/11. W dniu 20.09.2016 o 21:02, larsxschnei...@gmail.com pisze: > From: Lars Schneider > > Git's clean/smudge mechanism invokes an external filter process for > every single blob that is affected by a filter. If Git filters a lot of >

[PATCH v8 11/11] convert: add filter..process option

2016-09-20 Thread larsxschneider
From: Lars Schneider Git's clean/smudge mechanism invokes an external filter process for every single blob that is affected by a filter. If Git filters a lot of blobs then the startup time of the external filter processes can become a significant part of the overall Git