[PATCH v8 11/44] refs.c: change ref_transaction_create to do error checking and return status

2014-05-15 Thread Ronnie Sahlberg
Do basic error checking in ref_transaction_create() and make it return non-zero on error. Update all callers to check the result of ref_transaction_create(). There are currently no conditions in _create that will return error but there will be in the future. Signed-off-by: Ronnie Sahlberg

Re: [PATCH v8 11/44] refs.c: change ref_transaction_create to do error checking and return status

2014-05-15 Thread Jonathan Nieder
Ronnie Sahlberg wrote: Do basic error checking in ref_transaction_create() and make it return non-zero on error. Same thoughts as _update(). Basic idea is good but would be nice to have a 'struct strbuf *err' parameter. Thanks, Jonathan -- To unsubscribe from this list: send the line

Re: [PATCH v8 11/44] refs.c: change ref_transaction_create to do error checking and return status

2014-05-15 Thread Ronnie Sahlberg
On Thu, May 15, 2014 at 12:44 PM, Jonathan Nieder jrnie...@gmail.com wrote: Ronnie Sahlberg wrote: Do basic error checking in ref_transaction_create() and make it return non-zero on error. Same thoughts as _update(). Basic idea is good but would be nice to have a 'struct strbuf *err'