Re: [PATCH v9 6/8] convert: check for detectable errors in UTF encodings

On Sun, Mar 4, 2018 at 3:14 PM, wrote: > Check that new content is valid with respect to the user defined > 'working-tree-encoding' attribute. > > Signed-off-by: Lars Schneider > --- > diff --git a/convert.c b/convert.c > @@ -266,6 +266,53

Re: [PATCH v9 6/8] convert: check for detectable errors in UTF encodings

> On 06 Mar 2018, at 02:23, Junio C Hamano wrote: > > Lars Schneider writes: > >>> On 05 Mar 2018, at 22:50, Junio C Hamano wrote: >>> >>> lars.schnei...@autodesk.com writes: >>> +static int validate_encoding(const char

Re: [PATCH v9 6/8] convert: check for detectable errors in UTF encodings

Lars Schneider writes: >> On 05 Mar 2018, at 22:50, Junio C Hamano wrote: >> >> lars.schnei...@autodesk.com writes: >> >>> +static int validate_encoding(const char *path, const char *enc, >>> + const char *data, size_t len, int

Re: [PATCH v9 6/8] convert: check for detectable errors in UTF encodings

> On 05 Mar 2018, at 22:50, Junio C Hamano wrote: > > lars.schnei...@autodesk.com writes: > >> +static int validate_encoding(const char *path, const char *enc, >> + const char *data, size_t len, int die_on_error) >> +{ >> +if (!memcmp("UTF-", enc, 4)) {

Re: [PATCH v9 6/8] convert: check for detectable errors in UTF encodings

lars.schnei...@autodesk.com writes: > +static int validate_encoding(const char *path, const char *enc, > + const char *data, size_t len, int die_on_error) > +{ > + if (!memcmp("UTF-", enc, 4)) { Does the caller already know that enc is sufficiently long that using memcmp is

[PATCH v9 6/8] convert: check for detectable errors in UTF encodings

From: Lars Schneider Check that new content is valid with respect to the user defined 'working-tree-encoding' attribute. Signed-off-by: Lars Schneider --- convert.c| 50 +++