Re: [PATCHv2] push: heed user.signingkey for signed pushes

2014-10-24 Thread Junio C Hamano
Michael J Gruber writes: > Ooops, I'm sorry. That must have sneaked in from running gpg with that > home to see which keys we have in the test env. No change in trustdb > intended. Probably gpg did some automatic trustdb recalculations, even > though all I did was gpg --list-key. OK, so it will

Re: [PATCHv2] push: heed user.signingkey for signed pushes

2014-10-24 Thread Junio C Hamano
Michael J Gruber writes: > If I do that, I get: > > gpg: can't create `/home/mjg/src/git/t/trash > directory.t5534-push-signed/gpghome/random_seed': Permission denied > > So I we do copy the env around. Problems arise only when the original > copy ends up ro. We can guard against that by doing:

Re: [PATCHv2] push: heed user.signingkey for signed pushes

2014-10-24 Thread Michael J Gruber
Junio C Hamano schrieb am 23.10.2014 um 01:47: > Junio C Hamano writes: > >> Michael J Gruber writes: >> >>> push --signed promises to take user.signingkey as the signing key but >>> fails to read the config. >>> >>> Make it do so. >>> >>> Signed-off-by: Michael J Gruber >>> --- >>> Okay, I gue

Re: [PATCHv2] push: heed user.signingkey for signed pushes

2014-10-24 Thread Michael J Gruber
Junio C Hamano schrieb am 23.10.2014 um 00:05: > Michael J Gruber writes: > >> push --signed promises to take user.signingkey as the signing key but >> fails to read the config. >> >> Make it do so. >> >> Signed-off-by: Michael J Gruber >> --- >> Okay, I guess this is nicer. We do have the commi

Re: [PATCHv2] push: heed user.signingkey for signed pushes

2014-10-22 Thread Junio C Hamano
Junio C Hamano writes: > Michael J Gruber writes: > >> push --signed promises to take user.signingkey as the signing key but >> fails to read the config. >> >> Make it do so. >> >> Signed-off-by: Michael J Gruber >> --- >> Okay, I guess this is nicer. We do have the committer info in the env. S

Re: [PATCHv2] push: heed user.signingkey for signed pushes

2014-10-22 Thread Junio C Hamano
Michael J Gruber writes: > push --signed promises to take user.signingkey as the signing key but > fails to read the config. > > Make it do so. > > Signed-off-by: Michael J Gruber > --- > Okay, I guess this is nicer. We do have the committer info in the env. Sorry. > > builtin/push.c |

[PATCHv2] push: heed user.signingkey for signed pushes

2014-10-22 Thread Michael J Gruber
push --signed promises to take user.signingkey as the signing key but fails to read the config. Make it do so. Signed-off-by: Michael J Gruber --- Okay, I guess this is nicer. We do have the committer info in the env. Sorry. builtin/push.c | 13 - t/lib-gpg/trustdb.gpg |