Re: [PATCHv2 04/10] pkt-line: change error message for oversized packet

2013-02-20 Thread Jeff King
On Mon, Feb 18, 2013 at 04:33:31PM -0500, Jeff King wrote: On Mon, Feb 18, 2013 at 01:25:35PM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: But it's easy to do (1), and it starts the clock ticking for the 1000-byte readers to become obsolete. Yup, I agree with

Re: [PATCHv2 04/10] pkt-line: change error message for oversized packet

2013-02-20 Thread Junio C Hamano
Jeff King p...@peff.net wrote: In the meantime, please hold off on what I've posted so far (that includes the jk/smart-http-robustify topic). Surely. I'm done for the night already. Looking forward to see the reroll tomorrow. Thanks. -- Pardon terseness, typo and HTML from a tablet. -- To

[PATCHv2 04/10] pkt-line: change error message for oversized packet

2013-02-18 Thread Jeff King
If we get a packet from the remote side that is too large to fit in our buffer, we currently complain protocol error: bad line length. This is a bit vague. The line length the other side sent is not bad per se; the actual problem is that it exceeded our expectation for buffer length. This will

Re: [PATCHv2 04/10] pkt-line: change error message for oversized packet

2013-02-18 Thread Junio C Hamano
Jeff King p...@peff.net writes: I'm really tempted to bump all of our 1000-byte buffers to just use LARGE_PACKET_MAX. If we provided a packet_read variant that used a static buffer (which is fine for all but one or two callers), then it would not take much memory... I thought that 1000-byte

Re: [PATCHv2 04/10] pkt-line: change error message for oversized packet

2013-02-18 Thread Jeff King
On Mon, Feb 18, 2013 at 01:40:17AM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: I'm really tempted to bump all of our 1000-byte buffers to just use LARGE_PACKET_MAX. If we provided a packet_read variant that used a static buffer (which is fine for all but one or two

Re: [PATCHv2 04/10] pkt-line: change error message for oversized packet

2013-02-18 Thread Jeff King
On Mon, Feb 18, 2013 at 02:15:23AM -0800, Jonathan Nieder wrote: Jeff King wrote: --- a/pkt-line.c +++ b/pkt-line.c @@ -160,7 +160,8 @@ static int packet_read_internal(int fd, char *buffer, unsigned size, int gently) } len -= 4; if (len = size) -

Re: [PATCHv2 04/10] pkt-line: change error message for oversized packet

2013-02-18 Thread Junio C Hamano
Jeff King p...@peff.net writes: But it's easy to do (1), and it starts the clock ticking for the 1000-byte readers to become obsolete. Yup, I agree with that goal. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More

Re: [PATCHv2 04/10] pkt-line: change error message for oversized packet

2013-02-18 Thread Jeff King
On Mon, Feb 18, 2013 at 01:25:35PM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: But it's easy to do (1), and it starts the clock ticking for the 1000-byte readers to become obsolete. Yup, I agree with that goal. Having just looked at the pkt-line callers a lot, I think