Re: [PATCHv3 2/3] mailmap: use higher level string list functions

2014-11-30 Thread Junio C Hamano
Eric Sunshine sunsh...@sunshineco.com writes: On Thu, Nov 27, 2014 at 1:44 PM, Michael Blume blume.m...@gmail.com wrote: The variable index seems to be unused/uninitialized now -- it's still printed in debug messages, but if I'm reading correctly, its contents are going to be nonsense. Nice

Re: [PATCHv3 2/3] mailmap: use higher level string list functions

2014-11-30 Thread Stefan Beller
On 30.11.2014 16:47, Junio C Hamano wrote: Eric Sunshine sunsh...@sunshineco.com writes: On Thu, Nov 27, 2014 at 1:44 PM, Michael Blume blume.m...@gmail.com wrote: The variable index seems to be unused/uninitialized now -- it's still printed in debug messages, but if I'm reading correctly,

Re: [PATCHv3 2/3] mailmap: use higher level string list functions

2014-11-27 Thread Eric Sunshine
On Thu, Nov 27, 2014 at 1:44 PM, Michael Blume blume.m...@gmail.com wrote: The variable index seems to be unused/uninitialized now -- it's still printed in debug messages, but if I'm reading correctly, its contents are going to be nonsense. Nice catch. (Aside: Please don't top-post on this

[PATCHv3 2/3] mailmap: use higher level string list functions

2014-11-24 Thread Stefan Beller
No functional changes intended. This commit makes use of higher level and better documented functions of the string list API, so the code is more understandable. Note that also the required computational amount should not change in principal as we need to look up the item no matter if it is