Re: [PATCHv4 6/6] git-send-email: use git credential to obtain password

2013-02-27 Thread Junio C Hamano
Matthieu Moy writes: > Junio C Hamano writes: > >> diff --git a/git-send-email.perl b/git-send-email.perl >> index 76bbfc3..c3501d9 100755 >> --- a/git-send-email.perl >> +++ b/git-send-email.perl >> @@ -1045,6 +1045,14 @@ sub maildomain { >> return maildomain_net() || maildomain_mta() || '

Re: [PATCHv4 6/6] git-send-email: use git credential to obtain password

2013-02-27 Thread Matthieu Moy
Junio C Hamano writes: > diff --git a/git-send-email.perl b/git-send-email.perl > index 76bbfc3..c3501d9 100755 > --- a/git-send-email.perl > +++ b/git-send-email.perl > @@ -1045,6 +1045,14 @@ sub maildomain { > return maildomain_net() || maildomain_mta() || 'localhost.localdomain'; > } >

Re: [PATCHv4 6/6] git-send-email: use git credential to obtain password

2013-02-27 Thread Michal Nazarewicz
On Wed, Feb 27 2013, Junio C Hamano wrote: > Matthieu Moy writes: > >> Michal Nazarewicz writes: >> >>> + $auth = Git::credential({ >>> + 'protocol' => 'smtp', >>> + 'host' => join(':', $smtp_server, $smtp_server_port), >> >> At this point, $smtp_server_port is not always d

Re: [PATCHv4 6/6] git-send-email: use git credential to obtain password

2013-02-27 Thread Junio C Hamano
Matthieu Moy writes: > Michal Nazarewicz writes: > >> +$auth = Git::credential({ >> +'protocol' => 'smtp', >> +'host' => join(':', $smtp_server, $smtp_server_port), > > At this point, $smtp_server_port is not always defined. I just tested > and got > > Use of uninitia

Re: [PATCHv4 6/6] git-send-email: use git credential to obtain password

2013-02-27 Thread Matthieu Moy
Michal Nazarewicz writes: > + $auth = Git::credential({ > + 'protocol' => 'smtp', > + 'host' => join(':', $smtp_server, $smtp_server_port), At this point, $smtp_server_port is not always defined. I just tested and got Use of uninitialized value $smtp_server_port in j

[PATCHv4 6/6] git-send-email: use git credential to obtain password

2013-02-12 Thread Michal Nazarewicz
From: Michal Nazarewicz If smtp_user is provided but smtp_pass is not, instead of prompting for password, make git-send-email use git credential command instead. Signed-off-by: Michal Nazarewicz --- Documentation/git-send-email.txt | 4 +-- git-send-email.perl | 59 ++