Re: [RFC/PATCH 1/2] config: Add cache for config value querying

2014-05-28 Thread Eric Sunshine
On Mon, May 26, 2014 at 1:33 PM, Tanay Abhra tanay...@gmail.com wrote: Add an internal cache with the all variable value pairs read from the usual config files(repo specific .git/config, user wide ~/.gitconfig and the global s/(/ (/ /etc/gitconfig). Also, add two external functions

Re: [RFC/PATCH 1/2] config: Add cache for config value querying

2014-05-27 Thread Tanay Abhra
Hi, On 05/26/2014 01:02 PM, Torsten Bögershausen wrote: Add an internal cache with the all variable value pairs read from the usual cache: The word cache is in Git often used for index Okay, point noted. I thought about choosing between hashmap and cache and chose the later. variable value

[RFC/PATCH 1/2] config: Add cache for config value querying

2014-05-26 Thread Tanay Abhra
Add an internal cache with the all variable value pairs read from the usual config files(repo specific .git/config, user wide ~/.gitconfig and the global /etc/gitconfig). Also, add two external functions `git_config_get_string` and `git_config_get_string_multi` for querying in an non callback

Re: [RFC/PATCH 1/2] config: Add cache for config value querying

2014-05-26 Thread Torsten Bögershausen
On 2014-05-26 19.33, Tanay Abhra wrote: I like the idea. Please allow some minor comments (and read them as questions rather then answers) Add an internal cache with the all variable value pairs read from the usual cache: The word cache is in Git often used for index variable value can be