Re: [RFC/PATCH 1/2] config: Add safe-include directive

2014-10-06 Thread Rasmus Villemoes
Junio C Hamano gits...@pobox.com wrote: (by the way, we do not do dashes in names for configuration by convention) OK. Actually, I now think I'd prefer a subsection [include safe], but I don't have any strong preferences regarding the names. That syntax _could_ be just a relative path (e.g.

Re: [RFC/PATCH 1/2] config: Add safe-include directive

2014-10-06 Thread Junio C Hamano
Rasmus Villemoes r...@rasmusvillemoes.dk writes: Junio C Hamano gits...@pobox.com wrote: (by the way, we do not do dashes in names for configuration by convention) OK. Actually, I now think I'd prefer a subsection [include safe], but I don't have any strong preferences regarding the names.

Re: [RFC/PATCH 1/2] config: Add safe-include directive

2014-10-03 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Even though I did allude to ../project.gitconfig in the original message, I think there should probably be an explicit syntax to name a path that is relative to the root level of the working tree. People do funky things using $GIT_DIR and

[RFC/PATCH 1/2] config: Add safe-include directive

2014-10-02 Thread Rasmus Villemoes
This adds a variant of the include directive, where only certain config variables in the included files are honoured. The set of honoured variables consists of those the user has mentioned in a safe-include.whitelist directive, along with a small set of git.git blessed ones. This can, for

Re: [RFC/PATCH 1/2] config: Add safe-include directive

2014-10-02 Thread Junio C Hamano
On Thu, Oct 2, 2014 at 6:37 PM, Rasmus Villemoes r...@rasmusvillemoes.dk wrote: This adds a variant of the include directive, where only certain config variables in the included files are honoured. The set of honoured variables consists of those the user has mentioned in a

Re: [RFC/PATCH 1/2] config: Add safe-include directive

2014-10-02 Thread Junio C Hamano
On Thu, Oct 2, 2014 at 10:27 PM, Junio C Hamano gits...@pobox.com wrote: On Thu, Oct 2, 2014 at 6:37 PM, Rasmus Villemoes r...@rasmusvillemoes.dk wrote: This adds a variant of the include directive, where only certain config variables in the included files are honoured. The set of honoured