Re: [RFC/PATCH v11 02/13] bisect: rewrite `check_term_format` shell function in C

2016-08-03 Thread Pranit Bauva
Hey Junio, On Tue, Aug 2, 2016 at 11:01 PM, Junio C Hamano wrote: > Pranit Bauva writes: > >> +/* >> + * Check whether the string `term` belongs to the set of strings >> + * included in the variable arguments. >> + */ >> +static int one_of(const char

Re: [RFC/PATCH v11 02/13] bisect: rewrite `check_term_format` shell function in C

2016-08-02 Thread Junio C Hamano
Pranit Bauva writes: > +/* > + * Check whether the string `term` belongs to the set of strings > + * included in the variable arguments. > + */ > +static int one_of(const char *term, ...) > +{ > + int res = 0; > + va_list matches; > + const char *match; > + >

[RFC/PATCH v11 02/13] bisect: rewrite `check_term_format` shell function in C

2016-07-31 Thread Pranit Bauva
Reimplement the `check_term_format` shell function in C and add a `--check-term-format` subcommand to `git bisect--helper` to call it from git-bisect.sh Using `--check-term-format` subcommand is a temporary measure to port shell function to C so as to use the existing test suite. As more