Re: [RFC/PATCH v3 01/16] Add initial external odb support

2017-08-03 Thread Jeff King
On Thu, Aug 03, 2017 at 09:46:38AM +0200, Christian Couder wrote: > >> +static int external_odb_config(const char *var, const char *value, void > >> *data) > >> +{ > >> + struct odb_helper *o; > >> + const char *key, *dot; > >> + > >> + if (!skip_prefix(var, "odb.", )) > >> +

Re: [RFC/PATCH v3 01/16] Add initial external odb support

2017-08-03 Thread Christian Couder
On Thu, Dec 1, 2016 at 12:37 AM, Jeff King wrote: > On Wed, Nov 30, 2016 at 03:30:09PM -0800, Junio C Hamano wrote: > >> Christian Couder writes: >> >> > From: Jeff King >> > >> > Signed-off-by: Christian Couder

Re: [RFC/PATCH v3 01/16] Add initial external odb support

2017-08-03 Thread Christian Couder
(I realized that I didn't answer this email about the v3 version. Sorry about this late answer.) On Thu, Dec 1, 2016 at 12:30 AM, Junio C Hamano wrote: > Christian Couder writes: > >> From: Jeff King >> >> Signed-off-by: Christian

Re: [RFC/PATCH v3 01/16] Add initial external odb support

2016-11-30 Thread Jeff King
On Wed, Nov 30, 2016 at 03:30:09PM -0800, Junio C Hamano wrote: > Christian Couder writes: > > > From: Jeff King > > > > Signed-off-by: Christian Couder > > --- > > By the time the series loses RFC prefix, we'd need to see

Re: [RFC/PATCH v3 01/16] Add initial external odb support

2016-11-30 Thread Junio C Hamano
Christian Couder writes: > From: Jeff King > > Signed-off-by: Christian Couder > --- By the time the series loses RFC prefix, we'd need to see the above three lines straightened out a bit more, e.g. a real message and a more

[RFC/PATCH v3 01/16] Add initial external odb support

2016-11-30 Thread Christian Couder
From: Jeff King Signed-off-by: Christian Couder --- Makefile| 2 + cache.h | 9 ++ external-odb.c | 115 +++ external-odb.h | 8 ++ odb-helper.c| 239