Re: [RFC PATCH] git-p4: add option to store files in Git LFS on import

2015-09-03 Thread John Keeping
On Thu, Sep 03, 2015 at 11:40:20AM +0200, Lars Schneider wrote: > > On 30 Aug 2015, at 18:36, Luke Diamand wrote: > > > On 30 August 2015 at 11:18, Lars Schneider wrote: > >> Thanks for your feedback! > >> > >> I like the “handle big files” plugin kind of idea. However, I > >> wonder if it mak

Re: [RFC PATCH] git-p4: add option to store files in Git LFS on import

2015-09-03 Thread Luke Diamand
>>> >>> Regarding Python 3: >>> Would you drop Python 2 support or do you want to support Python 2/3 in >>> parallel? I would prefer the former… >> >> For quite some time we would need to support both; we can't just have >> a release of git that one day breaks git-p4 for people stuck on Python >>

Re: [RFC PATCH] git-p4: add option to store files in Git LFS on import

2015-09-03 Thread Lars Schneider
On 30 Aug 2015, at 18:36, Luke Diamand wrote: > On 30 August 2015 at 11:18, Lars Schneider wrote: >> Thanks for your feedback! >> >> I like the “handle big files” plugin kind of idea. However, I wonder if it >> makes sense to put more and more stuff into git-p4.py (>3000 LOC already). >> Wha

Re: [RFC PATCH] git-p4: add option to store files in Git LFS on import

2015-08-30 Thread Luke Diamand
On 30 August 2015 at 11:18, Lars Schneider wrote: > Thanks for your feedback! > > I like the “handle big files” plugin kind of idea. However, I wonder if it > makes sense to put more and more stuff into git-p4.py (>3000 LOC already). > What do you think about splitting git-p4 into multiple files

Re: [RFC PATCH] git-p4: add option to store files in Git LFS on import

2015-08-30 Thread Lars Schneider
Thanks for your feedback! I like the “handle big files” plugin kind of idea. However, I wonder if it makes sense to put more and more stuff into git-p4.py (>3000 LOC already). What do you think about splitting git-p4 into multiple files? Regarding Python 3: Would you drop Python 2 support or

Re: [RFC PATCH] git-p4: add option to store files in Git LFS on import

2015-08-30 Thread Luke Diamand
Comments below. > > diff --git a/Documentation/git-p4.txt b/Documentation/git-p4.txt > index 82aa5d6..a188840 100644 > --- a/Documentation/git-p4.txt > +++ b/Documentation/git-p4.txt > @@ -252,6 +252,18 @@ Git repository: > Use a client spec to find the list of interesting files in p4. >

Re: [RFC PATCH] git-p4: add option to store files in Git LFS on import

2015-08-30 Thread Luke Diamand
On 28 August 2015 at 13:24, wrote: > From: Lars Schneider > > I am migrating huge Perforce repositories including history to Git. Some of > them contain large files that would blow up the resulting Git repositories. > This patch adds an option to store these files in Git LFS [1] on git-p4 clon

[RFC PATCH] git-p4: add option to store files in Git LFS on import

2015-08-28 Thread larsxschneider
From: Lars Schneider Signed-off-by: Lars Schneider --- Documentation/git-p4.txt | 12 ++ git-p4.py| 94 ++-- t/t9822-git-p4-lfs.sh| 277 +++ 3 files changed, 374 insertions(+), 9 deletions(-) create mode 100755 t/t98

[RFC PATCH] git-p4: add option to store files in Git LFS on import

2015-08-28 Thread larsxschneider
From: Lars Schneider I am migrating huge Perforce repositories including history to Git. Some of them contain large files that would blow up the resulting Git repositories. This patch adds an option to store these files in Git LFS [1] on git-p4 clone. In order to run the unit tests you need to