Re: [RFC PATCH 2/8] commit: move code to update HEAD to libgit

2017-10-24 Thread Junio C Hamano
Phillip Wood writes: >> I suspect that it would be sufficient to make update_head() helper >> function take the reflog action message as another parameter >> instead to fix the above, but there may be other reasons why you >> chose to do it this way---I cannot read it in your empty log >> message

Re: [RFC PATCH 2/8] commit: move code to update HEAD to libgit

2017-10-24 Thread Phillip Wood
On 07/10/17 10:54, Junio C Hamano wrote: > Phillip Wood writes: > >> From: Phillip Wood >> >> Signed-off-by: Phillip Wood >> --- > > This seems to do a lot more than just moving code, most notably, it > uses setenv() to affect what happens in any subprocesses we may > spawn, and it is unclear

Re: [RFC PATCH 2/8] commit: move code to update HEAD to libgit

2017-10-07 Thread Junio C Hamano
Phillip Wood writes: > From: Phillip Wood > > Signed-off-by: Phillip Wood > --- This seems to do a lot more than just moving code, most notably, it uses setenv() to affect what happens in any subprocesses we may spawn, and it is unclear if it was verified that this patch is free of unwanted co

[RFC PATCH 2/8] commit: move code to update HEAD to libgit

2017-09-25 Thread Phillip Wood
From: Phillip Wood Signed-off-by: Phillip Wood --- builtin/commit.c | 31 +++ sequencer.c | 39 ++- sequencer.h | 2 ++ 3 files changed, 47 insertions(+), 25 deletions(-) diff --git a/builtin/commit.c b/builtin/commit.c