Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-12 Thread Junio C Hamano
Jeff King writes: > In my experience the maintenance burden is not in the "connect to a > socket" part, but the fact that you have to sprinkle the entry points > throughout the code (e.g., "set 'cloning' flag to 1" or "I'm entering > the pack generation phase of the fetch"). So I'd love to see

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-11 Thread Jeff King
On Mon, Jun 11, 2018 at 02:14:41AM -0400, Jeff King wrote: > On Sun, Jun 10, 2018 at 12:00:57AM +, brian m. carlson wrote: > > > I also have to look at this issue from the interests of what is best for > > the FLOSS community and for users as a whole. Adding in functionality > > that sends

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-11 Thread Jeff King
On Sun, Jun 10, 2018 at 12:00:57AM +, brian m. carlson wrote: > I also have to look at this issue from the interests of what is best for > the FLOSS community and for users as a whole. Adding in functionality > that sends off usage data from a command-line tool, especially one that > is as

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-11 Thread Jeff King
On Sun, Jun 10, 2018 at 12:44:25AM +0200, Johannes Sixt wrote: > > I agree with Peff: this is something you as a user need to be aware of, > > and need to make sure you configure your Git just like you want. As long > > as this is a purely opt-in feature, it is useful and helpful. > > The

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-10 Thread Jeff King
On Sat, Jun 09, 2018 at 10:05:49PM +0200, Johannes Schindelin wrote: > > E.g., could we have a flag or environment variable to have the existing > > traces output JSON? I guess right now they're inherently free-form via > > trace_printf, so it would involve adding some structured interface > >

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-09 Thread brian m. carlson
On Sat, Jun 09, 2018 at 08:56:00AM +0200, Johannes Sixt wrote: > Am 09.06.2018 um 00:20 schrieb Ævar Arnfjörð Bjarmason: > > > > On Fri, Jun 08 2018, Johannes Sixt wrote: > > Can you elaborate on how someone who can maintain inject malicious code > > into your git package + config would be

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-09 Thread Johannes Sixt
Am 09.06.2018 um 22:43 schrieb Johannes Schindelin: On Sat, 9 Jun 2018, Johannes Sixt wrote: When you want usage data, ask your users for feedback. Look over their shoulders. But do not ask the software itself to gather usage data. It will be abused. Do not offer open source software that has

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-09 Thread Johannes Schindelin
Hi Hannes, On Sat, 9 Jun 2018, Johannes Sixt wrote: > Am 09.06.2018 um 00:20 schrieb Ævar Arnfjörð Bjarmason: > > > > On Fri, Jun 08 2018, Johannes Sixt wrote: > > > > > Am 08.06.2018 um 18:00 schrieb Thomas Braun: > > > > I for my part would much rather prefer that to be a compile time > > >

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-09 Thread Johannes Schindelin
Hi Peff, On Sat, 9 Jun 2018, Jeff King wrote: > On Sat, Jun 09, 2018 at 08:31:58AM +0200, Ævar Arnfjörð Bjarmason wrote: > > > 1) I really don't see the basis for this argument that they'd need to > >patch it out, they're not patching out e.g. GIT_TRACE now, which has > >all the same

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-09 Thread Duy Nguyen
On Sat, Jun 9, 2018 at 8:32 AM Ævar Arnfjörð Bjarmason wrote: > Let's say you're in a corporate environment with Linux, OSX and Windows > boxes, but all of whom have some shared mounts provisioned & ability to > ship an /etc/gitconfig (wherever that lives on Windows). > > It's much easier to just

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-09 Thread Jeff King
On Sat, Jun 09, 2018 at 09:04:16AM +0200, Johannes Sixt wrote: > > AFAICT this telemetry data is the same thing, but for performance. When > > somebody says "why does this command take so long", wouldn't it be nice > > for us to be able to tell them to flip a switch that will collect data > > on

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-09 Thread Johannes Sixt
Am 09.06.2018 um 08:51 schrieb Jeff King: I actually think this could be useful for normal users, too. We have GIT_TRACE for dumping debug output, and we sometimes ask users to turn it on to help diagnose a problem (not to mention that we use it ourselves). The BIG difference is in "we ask the

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-09 Thread Jeff King
On Sat, Jun 09, 2018 at 08:31:58AM +0200, Ævar Arnfjörð Bjarmason wrote: > 1) I really don't see the basis for this argument that they'd need to >patch it out, they're not patching out e.g. GIT_TRACE now, which has >all the same sort of concerns, it's just a format that's more of a >

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-09 Thread Johannes Sixt
Am 09.06.2018 um 00:20 schrieb Ævar Arnfjörð Bjarmason: On Fri, Jun 08 2018, Johannes Sixt wrote: Am 08.06.2018 um 18:00 schrieb Thomas Braun: I for my part would much rather prefer that to be a compile time option so that I don't need to check on every git update on windows if this is now

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-09 Thread Jeff King
On Sat, Jun 09, 2018 at 07:03:53AM +0200, Duy Nguyen wrote: > > > Am 08.06.2018 um 18:00 schrieb Thomas Braun: > > >> I for my part would much rather prefer that to be a compile time > > >> option so that I don't need to check on every git update on windows > > >> if this is now enabled or not.

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-09 Thread Ævar Arnfjörð Bjarmason
On Sat, Jun 09 2018, Duy Nguyen wrote: > On Sat, Jun 9, 2018 at 12:22 AM Ævar Arnfjörð Bjarmason > wrote: >> >> >> On Fri, Jun 08 2018, Johannes Sixt wrote: >> >> > Am 08.06.2018 um 18:00 schrieb Thomas Braun: >> >> I for my part would much rather prefer that to be a compile time >> >> option

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-08 Thread Duy Nguyen
On Sat, Jun 9, 2018 at 12:22 AM Ævar Arnfjörð Bjarmason wrote: > > > On Fri, Jun 08 2018, Johannes Sixt wrote: > > > Am 08.06.2018 um 18:00 schrieb Thomas Braun: > >> I for my part would much rather prefer that to be a compile time > >> option so that I don't need to check on every git update on

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-08 Thread Ævar Arnfjörð Bjarmason
On Fri, Jun 08 2018, Johannes Sixt wrote: > Am 08.06.2018 um 18:00 schrieb Thomas Braun: >> I for my part would much rather prefer that to be a compile time >> option so that I don't need to check on every git update on windows >> if this is now enabled or not. > > This exactly my concern,

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-08 Thread Johannes Sixt
Am 08.06.2018 um 18:00 schrieb Thomas Braun: I for my part would much rather prefer that to be a compile time option so that I don't need to check on every git update on windows if this is now enabled or not. This exactly my concern, too! A compile-time option may make it a good deal less

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-08 Thread Thomas Braun
Am 08.06.2018 um 11:07 schrieb Jeff King: > On Thu, Jun 07, 2018 at 11:10:52PM +0200, Johannes Sixt wrote: > >> Am 07.06.2018 um 16:53 schrieb g...@jeffhostetler.com: >>> From: Jeff Hostetler >>> >>> I've been working to add code to Git to optionally collect telemetry data. >>> The goal is to be

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-08 Thread Duy Nguyen
On Fri, Jun 8, 2018 at 11:40 AM, Ævar Arnfjörð Bjarmason wrote: > > On Thu, Jun 07 2018, Johannes Sixt wrote: > >> Am 07.06.2018 um 16:53 schrieb g...@jeffhostetler.com: >>> From: Jeff Hostetler >>> >>> I've been working to add code to Git to optionally collect telemetry data. >>> The goal is to

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-08 Thread Ævar Arnfjörð Bjarmason
On Thu, Jun 07 2018, Johannes Sixt wrote: > Am 07.06.2018 um 16:53 schrieb g...@jeffhostetler.com: >> From: Jeff Hostetler >> >> I've been working to add code to Git to optionally collect telemetry data. >> The goal is to be able to collect performance data from Git commands and >> allow it to

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-08 Thread Jeff King
On Thu, Jun 07, 2018 at 11:10:52PM +0200, Johannes Sixt wrote: > Am 07.06.2018 um 16:53 schrieb g...@jeffhostetler.com: > > From: Jeff Hostetler > > > > I've been working to add code to Git to optionally collect telemetry data. > > The goal is to be able to collect performance data from Git

Re: [RFC PATCH v1] telemetry design overview (part 1)

2018-06-07 Thread Johannes Sixt
Am 07.06.2018 um 16:53 schrieb g...@jeffhostetler.com: From: Jeff Hostetler I've been working to add code to Git to optionally collect telemetry data. The goal is to be able to collect performance data from Git commands and allow it to be aggregated over a user community to find "slow

[RFC PATCH v1] telemetry design overview (part 1)

2018-06-07 Thread git
From: Jeff Hostetler I've been working to add code to Git to optionally collect telemetry data. The goal is to be able to collect performance data from Git commands and allow it to be aggregated over a user community to find "slow commands". I'm going to break this up into several parts rather