Re: BUG: 'error: invalid key: pager.show_ref' on 'git show_ref'

2015-02-06 Thread Junio C Hamano
Jeff King p...@peff.net writes: This is highlighting the problem with pager.* that Junio mentioned recently, which is that the keyname has arbitrary data,... Yes, even if it is not arbitrary (imagine we limit ourselves to the official set of commands we know about), the naming rule for the git

Re: BUG: 'error: invalid key: pager.show_ref' on 'git show_ref'

2015-02-06 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Fri, Feb 06, 2015 at 01:45:28PM +0100, Andreas Krey wrote: $ git show_ref error: invalid key: pager.show_ref error: invalid key: alias.show_ref git: 'show_ref' is not a git command. See 'git --help'. Apparently we need to squelch this message

Re: BUG: 'error: invalid key: pager.show_ref' on 'git show_ref'

2015-02-06 Thread Jeff King
On Fri, Feb 06, 2015 at 11:44:38AM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: On Fri, Feb 06, 2015 at 01:45:28PM +0100, Andreas Krey wrote: $ git show_ref error: invalid key: pager.show_ref error: invalid key: alias.show_ref git: 'show_ref' is not a git

Re: BUG: 'error: invalid key: pager.show_ref' on 'git show_ref'

2015-02-06 Thread Junio C Hamano
Jeff King p...@peff.net writes: That is one of the reasons why I had the unbounded set, including the ones under our control such as subcommand names in the draft update for the guideline. I dropped that part after the discussion to keep other obviously agreed parts moving, but we may have

Re: BUG: 'error: invalid key: pager.show_ref' on 'git show_ref'

2015-02-06 Thread Junio C Hamano
Jeff King p...@peff.net writes: A list of enum-like values where we are OK confining the names to the alnums is OK to use as an unbounded set of key values. Just like we have color.branch.*, we just pick a name within that syntax for any new values we add (and that is not even a burden; alnum

Re: BUG: 'error: invalid key: pager.show_ref' on 'git show_ref'

2015-02-06 Thread Jeff King
On Sat, Feb 07, 2015 at 01:03:15AM +0100, Mikael Magnusson wrote: On Fri, Feb 6, 2015 at 8:44 PM, Junio C Hamano gits...@pobox.com wrote: Jeff King p...@peff.net writes: On Fri, Feb 06, 2015 at 01:45:28PM +0100, Andreas Krey wrote: $ git show_ref error: invalid key:

Re: BUG: 'error: invalid key: pager.show_ref' on 'git show_ref'

2015-02-06 Thread Jeff King
On Fri, Feb 06, 2015 at 02:27:31PM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: A list of enum-like values where we are OK confining the names to the alnums is OK to use as an unbounded set of key values. Just like we have color.branch.*, we just pick a name within that

Re: BUG: 'error: invalid key: pager.show_ref' on 'git show_ref'

2015-02-06 Thread Mikael Magnusson
On Fri, Feb 6, 2015 at 8:44 PM, Junio C Hamano gits...@pobox.com wrote: Jeff King p...@peff.net writes: On Fri, Feb 06, 2015 at 01:45:28PM +0100, Andreas Krey wrote: $ git show_ref error: invalid key: pager.show_ref error: invalid key: alias.show_ref git: 'show_ref' is not a git

Re: BUG: 'error: invalid key: pager.show_ref' on 'git show_ref'

2015-02-06 Thread Jeff King
On Fri, Feb 06, 2015 at 01:45:28PM +0100, Andreas Krey wrote: there seems to be a regression in the behaviour of 'git show_ref' (note the underscore). In v2.0.3-711-g586f414 it starts to say: $ ./git show_ref error: invalid key: pager.show_ref git: 'show_ref' is not a git command.

Re: BUG: 'error: invalid key: pager.show_ref' on 'git show_ref'

2015-02-06 Thread Jeff King
On Fri, Feb 06, 2015 at 12:14:35PM -0800, Junio C Hamano wrote: Jeff King p...@peff.net writes: This is highlighting the problem with pager.* that Junio mentioned recently, which is that the keyname has arbitrary data,... Yes, even if it is not arbitrary (imagine we limit ourselves to

BUG: 'error: invalid key: pager.show_ref' on 'git show_ref'

2015-02-06 Thread Andreas Krey
Hi all, there seems to be a regression in the behaviour of 'git show_ref' (note the underscore). In v2.0.3-711-g586f414 it starts to say: $ ./git show_ref error: invalid key: pager.show_ref git: 'show_ref' is not a git command. See 'git --help'. and somewhere (probably two commits,