Re: BUG: fetch in certain repo always gives "did not send all necessary objects"

2018-02-07 Thread Jeff King
On Wed, Feb 07, 2018 at 09:25:42AM -0800, Elijah Newren wrote: > > So other_head_refs knows that it's looking at the worktrees. And it > > passes the alternate ref-store to refs_head_ref(), with "add_one_ref" as > > the callback. But the knowledge that we're not talking about the real > > "HEAD"

Re: BUG: fetch in certain repo always gives "did not send all necessary objects"

2018-02-07 Thread Elijah Newren
On Wed, Feb 7, 2018 at 3:08 AM, Duy Nguyen wrote: > On Wed, Feb 7, 2018 at 7:00 AM, Elijah Newren wrote: >> and knew they had been using it, then I might have guessed that "HEAD" >> meant "not your actual HEAD but the HEAD of the vestige of some other >>

Re: BUG: fetch in certain repo always gives "did not send all necessary objects"

2018-02-07 Thread Elijah Newren
On Wed, Feb 7, 2018 at 5:21 AM, Jeff King wrote: > On Tue, Feb 06, 2018 at 04:00:32PM -0800, Elijah Newren wrote: > >> It took me hours to figure it out, after users ran out of ideas and >> came and asked me for help. (Maybe if I was familiar with worktree, >> and knew they had

Re: BUG: fetch in certain repo always gives "did not send all necessary objects"

2018-02-07 Thread Jeff King
On Wed, Feb 07, 2018 at 08:21:57AM -0500, Jeff King wrote: > The best PSA for this particular bug may be "try pruning the worktrees": > > $ git worktree prune -v > Removing worktrees/foo: gitdir file points to non-existent location > > $ git prune; echo $? > 0 Sorry, I just read

Re: BUG: fetch in certain repo always gives "did not send all necessary objects"

2018-02-07 Thread Jeff King
On Wed, Feb 07, 2018 at 06:08:40PM +0700, Duy Nguyen wrote: > > And/or ideas of what steps could cause corruption so I can send out a > > PSA to help users avoid it? > > There is another thing we could do. One bad HEAD should not abort the > entire operation (at least if it's not the current

Re: BUG: fetch in certain repo always gives "did not send all necessary objects"

2018-02-07 Thread Jeff King
On Tue, Feb 06, 2018 at 04:00:32PM -0800, Elijah Newren wrote: > > According to Peff this got fixed > > https://public-inbox.org/git/20171020031630.44zvzh3d2vlhg...@sigill.intra.peff.net/ > > and but you've had a corrupted repo from back when you were using an older > > version of Git. > > > >

Re: BUG: fetch in certain repo always gives "did not send all necessary objects"

2018-02-07 Thread Duy Nguyen
On Wed, Feb 7, 2018 at 7:00 AM, Elijah Newren wrote: > and knew they had been using it, then I might have guessed that "HEAD" > meant "not your actual HEAD but the HEAD of the vestige of some other > worktree"). > > Does anyone have pointers about what might be doable in terms

Re: BUG: fetch in certain repo always gives "did not send all necessary objects"

2018-02-06 Thread Elijah Newren
On Tue, Feb 6, 2018 at 3:20 PM, Stefan Beller wrote: > On Tue, Feb 6, 2018 at 3:04 PM, Elijah Newren wrote: > >> >> Does anyone have an idea what may have happened here or how to avoid it? > > According to Peff this got fixed >

Re: BUG: fetch in certain repo always gives "did not send all necessary objects"

2018-02-06 Thread Stefan Beller
On Tue, Feb 6, 2018 at 3:04 PM, Elijah Newren wrote: > > Does anyone have an idea what may have happened here or how to avoid it? According to Peff this got fixed https://public-inbox.org/git/20171020031630.44zvzh3d2vlhg...@sigill.intra.peff.net/ and but you've had a corrupted

BUG: fetch in certain repo always gives "did not send all necessary objects"

2018-02-06 Thread Elijah Newren
[I cannot share the local repo and had to modify output of commands slightly to redact hostnames, branch names, etc. I think I haven't messed anything up, but it's possible...] Two people in the last week have come to me after running into a case where they could not update their repo because