Re: Minor bug, git ls-files -o aborts because of broken submodules

2016-01-25 Thread Andreas Krey
On Fri, 22 Jan 2016 17:26:50 +, Jeff King wrote: ... > Here it is. I think this is the right fix, based on the previous attempt > by Andreas and my comments. Sorry for stealing your topic, This seems to keep happening with things I try to patch. :-) > but I hope > the perf numbers in the

Re: Minor bug, git ls-files -o aborts because of broken submodules

2016-01-22 Thread Jeff King
On Fri, Jan 22, 2016 at 04:17:29PM +0700, Duy Nguyen wrote: > $ git init abc > $ cd abc > $ mkdir def > $ echo 'gitdir: blah blah' >def/.git > $ git ls-files -o > fatal: Not a git repository: def/blah blah > > If some directory looks like a submodule but turns out not, that's not > a fatal

Minor bug, git ls-files -o aborts because of broken submodules

2016-01-22 Thread Duy Nguyen
$ git init abc $ cd abc $ mkdir def $ echo 'gitdir: blah blah' >def/.git $ git ls-files -o fatal: Not a git repository: def/blah blah If some directory looks like a submodule but turns out not, that's not a fatal error. The stack trace is something like this. I suspect do_submodule_path should

Re: Minor bug, git ls-files -o aborts because of broken submodules

2016-01-22 Thread Jeff King
On Fri, Jan 22, 2016 at 04:18:03PM -0500, Jeff King wrote: > But I think this is another case of > > http://thread.gmane.org/gmane.comp.version-control.git/265560/focus=281253 > > There the question was about performance (lots of these clog up the > linear ref_cache list), but I think the