Re: Misleading documentation for git-diff-files (diff-filter)

2018-01-04 Thread John Cheng
Thanks for the clarification! I also didn't realize that diff-files -R will show added files. You learn something new everyday ;) On Thu, Jan 4, 2018 at 11:09 AM, Junio C Hamano wrote: > Jeff King writes: > >> diff --git a/Documentation/diff-options.txt

Re: Misleading documentation for git-diff-files (diff-filter)

2018-01-04 Thread Junio C Hamano
Jeff King writes: > diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt > index 9d1586b956..743af97b06 100644 > --- a/Documentation/diff-options.txt > +++ b/Documentation/diff-options.txt > @@ -469,6 +469,12 @@ ifndef::git-format-patch[] > + > Also,

Re: Misleading documentation for git-diff-files (diff-filter)

2018-01-04 Thread Jeff King
On Thu, Jan 04, 2018 at 07:53:53AM -0800, John Cheng wrote: > To be clear, I don't mean to imply that diff-files should include > files that are not the index. I was trying to say that as a user, the > documentation gave me a different impression. > > For background, my intent was to have a

Re: Misleading documentation for git-diff-files (diff-filter)

2018-01-04 Thread John Cheng
To be clear, I don't mean to imply that diff-files should include files that are not the index. I was trying to say that as a user, the documentation gave me a different impression. For background, my intent was to have a script to look for local git repos that with unstaged changes. After some

Re: Misleading documentation for git-diff-files (diff-filter)

2018-01-03 Thread Junio C Hamano
John Cheng writes: > I wanted to know if git diff-files shows files that are not in the > index but are in the working tree. At least in the original design of Git, that would fundamentally be impossible, as Git _only_ cares about paths that are in the index, so a new

Misleading documentation for git-diff-files (diff-filter)

2018-01-03 Thread John Cheng
I originally asked this question on stackoverflow (https://stackoverflow.com/q/48039277). I wanted to know if git diff-files shows files that are not in the index but are in the working tree. The documentation says you can supply --diff-filter=A, which will select file "that are added". However,