Re: [1/5] Parsing code in revision.h

2005-04-17 Thread Linus Torvalds
On Sun, 17 Apr 2005, Linus Torvalds wrote: > > Yes. I'm not opposed to yours, I was just opposed to some of the things > around it you did, so I wrote mine as a kind of place-holder. I'll happily > take patches to turn it from a rally simple and stupid one into a more > polished version. Btw

Re: [1/5] Parsing code in revision.h

2005-04-17 Thread Daniel Barkalow
On Sun, 17 Apr 2005, Linus Torvalds wrote: > On Sun, 17 Apr 2005, Linus Torvalds wrote: > > > > Yes. I'm not opposed to yours, I was just opposed to some of the things > > around it you did, so I wrote mine as a kind of place-holder. I'll happily > > take patches to turn it from a rally simple

Re: [1/5] Parsing code in revision.h

2005-04-17 Thread Linus Torvalds
On Sun, 17 Apr 2005, Daniel Barkalow wrote: > > Yours reads the whole commit history; I intentionally wrote mine to > only read as far back as turns out to be necessary. Yes. I'm not opposed to yours, I was just opposed to some of the things around it you did, so I wrote mine as a kind of plac

Re: [1/5] Parsing code in revision.h

2005-04-17 Thread Daniel Barkalow
On Sun, 17 Apr 2005, Linus Torvalds wrote: > On Sun, 17 Apr 2005, Petr Baudis wrote: > > > > Someone started the avalanche by adding date to the structure. Of > > course, date is smaller, but it leads people (including me) out of the > > way. > > Yeah, the naming and the structure comes from "re

Re: [1/5] Parsing code in revision.h

2005-04-17 Thread Linus Torvalds
On Sun, 17 Apr 2005, Petr Baudis wrote: > > Someone started the avalanche by adding date to the structure. Of > course, date is smaller, but it leads people (including me) out of the > way. Yeah, the naming and the structure comes from "rev-tree.c", so there's a bit of historical baggage alrea

Re: [1/5] Parsing code in revision.h

2005-04-17 Thread Daniel Barkalow
On Sun, 17 Apr 2005, Linus Torvalds wrote: > On Sun, 17 Apr 2005, Daniel Barkalow wrote: > > > > --- 45f926575d2c44072bfcf2317dbf3f0fbb513a4e/revision.h (mode:100644 > > sha1:28d0de3261a61f68e4e0948a25a416a515cd2e83) > > +++ 37a0b01b85c2999243674d48bfc71cdba0e5518e/revision.h (mode:100644 > >

Re: [1/5] Parsing code in revision.h

2005-04-17 Thread Petr Baudis
Dear diary, on Sun, Apr 17, 2005 at 08:18:47PM CEST, I got a letter where Linus Torvalds <[EMAIL PROTECTED]> told me that... > > > On Sun, 17 Apr 2005, Daniel Barkalow wrote: > > > > --- 45f926575d2c44072bfcf2317dbf3f0fbb513a4e/revision.h (mode:100644 > > sha1:28d0de3261a61f68e4e0948a25a416a515

Re: [1/5] Parsing code in revision.h

2005-04-17 Thread Linus Torvalds
On Sun, 17 Apr 2005, Daniel Barkalow wrote: > > --- 45f926575d2c44072bfcf2317dbf3f0fbb513a4e/revision.h (mode:100644 > sha1:28d0de3261a61f68e4e0948a25a416a515cd2e83) > +++ 37a0b01b85c2999243674d48bfc71cdba0e5518e/revision.h (mode:100644 > sha1:523bde6e14e18bb0ecbded8f83ad4df93fc467ab) > @@ -2

Re: Parsing code in revision.h

2005-04-17 Thread Daniel Barkalow
On Sun, 17 Apr 2005, Petr Baudis wrote: > Dear diary, on Sun, Apr 17, 2005 at 05:24:20PM CEST, I got a letter > where Daniel Barkalow <[EMAIL PROTECTED]> told me that... > > This adds support to revision.h for parsing commit records (but not going > > any further than parsing a single record). Som

Re: Parsing code in revision.h

2005-04-17 Thread Petr Baudis
Dear diary, on Sun, Apr 17, 2005 at 05:24:20PM CEST, I got a letter where Daniel Barkalow <[EMAIL PROTECTED]> told me that... > This adds support to revision.h for parsing commit records (but not going > any further than parsing a single record). Something like this is needed > by anything that use

[1/5] Parsing code in revision.h

2005-04-17 Thread Daniel Barkalow
This adds support to revision.h for parsing commit records (but not going any further than parsing a single record). Something like this is needed by anything that uses revision.h, but older programs open-code it. Signed-Off-By: Daniel Barkalow <[EMAIL PROTECTED]> Index: revision.h ===