Re: [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404

2018-01-16 Thread Junio C Hamano
Tanay Abhra writes: > I was the original author of the test, I am sorry about the typo. > ... > 'configset_get_value' will be changed to 'configset_get_value_multi' > since the test expects a list of values instead of a single value. Thanks for a quick reaction!!

Re: [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404

2018-01-12 Thread Tanay Abhra
On Fri, Jan 12, 2018 at 5:27 PM, Junio C Hamano wrote: > > "Randall S. Becker" writes: > > > Sadly, fixing the "except" thing causes the test to break now. > > That is exactly what I wanted to say. If you want to "fix" it, > you'd need to figure out

Re: [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404

2018-01-12 Thread Junio C Hamano
"Randall S. Becker" writes: > Sadly, fixing the "except" thing causes the test to break now. That is exactly what I wanted to say. If you want to "fix" it, you'd need to figure out what the author of the "except" thing wanted to test, adjust the args given to

RE: [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404

2018-01-12 Thread Randall S. Becker
On January 12, 2018 5:08 PM, Junio C Hamano wrote: > "Randall S. Becker" writes: > > It looks like the exit code is coming back as 1 not 2. There is also a > > file except vs expect. > > ./trash directory.t1308-config-set: ls a-directory actual config2 > > except expect

Re: [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404

2018-01-12 Thread Junio C Hamano
"Randall S. Becker" writes: > It looks like the exit code is coming back as 1 not 2. There is > also a file except vs expect. > ./trash directory.t1308-config-set: ls > a-directory actual config2 except expect output result The test that leaves "except" does look

RE: [ANNOUNCE] Git v2.16.0-rc2 - breakages in t1308 and 1404

2018-01-12 Thread Randall S. Becker
On January 11, 2018 11:11 PM, Junio C Hamano wrote: > A release candidate Git v2.16.0-rc2 is now available for testing at the usual > places. It is comprised of 483 non-merge commits since v2.15.0, contributed > by 80 people, 23 of which are new faces. Please forgive my not knowing the proper