RE: unused variable in hashmap.h [was: Re: [PATCH] Fixed pervasive enumeration warning in convert.h.]

2018-01-13 Thread Randall S. Becker
> Sent: On January 13, 2018 12:13 PM, René Scharfe wrote: > Am 12.01.2018 um 20:52 schrieb Randall S. Becker: > > On a related too many warnings subject, hashmap.h has a variable > > unused (void *item). Is that addressed soon? If not, I can deal with > > it. > Here are the code lines containing

unused variable in hashmap.h [was: Re: [PATCH] Fixed pervasive enumeration warning in convert.h.]

2018-01-13 Thread René Scharfe
Am 12.01.2018 um 20:52 schrieb Randall S. Becker: > On a related too many warnings subject, hashmap.h has a variable > unused (void *item). Is that addressed soon? If not, I can deal with > it. Here are the code lines containing the variable in question: void *item; while ((item =

RE: [PATCH] Fixed pervasive enumeration warning in convert.h.

2018-01-12 Thread Randall S. Becker
> From: Junio C Hamano [mailto:gits...@pobox.com] On January 12, 2018 2:25 PM, Junio C Hamano wrote: > > From: "Randall S. Becker" > > { > > - return convert_to_git(istate, path, NULL, 0, NULL, 0); > > + return convert_to_git(istate, path, NULL, 0, NULL, >

Re: [PATCH] Fixed pervasive enumeration warning in convert.h.

2018-01-12 Thread Junio C Hamano
randall.s.bec...@rogers.com writes: > From: "Randall S. Becker" > > The actual enum value should be used rather than 0 and was causing > a warning in an inline proc. > > Signed-off-by: Randall S. Becker > --- > convert.h | 2 +- > 1 file changed,