RE: [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings

[Randall S. Becker]

On January 14, 2018 12:25 PM, Philip Oakley wrote:
> To: randall.s.bec...@rogers.com; git@vger.kernel.org
> Cc: Randall S. Becker <rsbec...@nexbridge.com>
> Subject: Re: [PATCH] Remoted unnecessary void* from hashmap.h that
> caused compile warnings
> 
> From: <randall.s.bec...@rogers.com>
> Subject: [PATCH] Remoted unnecessary void* from hashmap.h that caused
> compile warnings
> 
> s/Remoted/Removed/ ?
> 
> Maybe shorten to " hashmap.h: remove unnecessary void* " (ex the
> superflous
> spaces)

I amended the commit fixing the typo and cleaning up the comment.

Thanks,
Randall

Re: [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings

[Philip Oakley]

From: 
Subject: [PATCH] Remoted unnecessary void* from hashmap.h that caused 
compile warnings


s/Remoted/Removed/ ?

Maybe shorten to " hashmap.h: remove unnecessary void* " (ex the superflous 
spaces)

--
Philip



From: "Randall S. Becker" 

* The while loop in the inline method hashmap_enable_item_counting
 used an unneeded variable. The loop has been revised accordingly.

Signed-off-by: Randall S. Becker 
---
hashmap.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hashmap.h b/hashmap.h
index 7ce79f3..d375d9c 100644
--- a/hashmap.h
+++ b/hashmap.h
@@ -400,7 +400,6 @@ static inline void 
hashmap_disable_item_counting(struct hashmap *map)

 */
static inline void hashmap_enable_item_counting(struct hashmap *map)
{
- void *item;
 unsigned int n = 0;
 struct hashmap_iter iter;

@@ -408,7 +407,7 @@ static inline void hashmap_enable_item_counting(struct 
hashmap *map)

 return;

 hashmap_iter_init(map, );
- while ((item = hashmap_iter_next()))
+ while (hashmap_iter_next())
 n++;

 map->do_count_items = 1;
--
2.8.5.23.g6fa7ec3