RE: [PATCH] Use unsigned char to squash compiler warnings

2015-03-04 Thread Randall S. Becker
>On 4 Mar 2015, Junio C Hamano Wrote: > Sent: March 4, 2015 5:11 PM > To: Ben Walton > Cc: git@vger.kernel.org > Subject: Re: [PATCH] Use unsigned char to squash compiler warnings > > Ben Walton writes: > > > On Mon, Mar 2, 2015 at 8:30 PM Junio C Hamano > wrot

Re: [PATCH] Use unsigned char to squash compiler warnings

2015-03-04 Thread Junio C Hamano
Ben Walton writes: > On Mon, Mar 2, 2015 at 8:30 PM Junio C Hamano wrote: > >> The conversion looked good from a cursory view; I didn't check it >> very carefully though. >> > Yes, because of the Solaris ABI, the Studio compiler defaults char to > signed char. Doesn't our beloved GCC also uses

Re: [PATCH] Use unsigned char to squash compiler warnings

2015-03-02 Thread Junio C Hamano
Ben Walton writes: > Sun Studio on Solaris issues warnings about improper initialization > values being used when defining tolower_trans_tbl in > ctype.c. tolower_trans_tbl is defined as char[], which studio's > compiler defaults to signed char[] due to the Solaris ABI. To resolve > this, instead