RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-05 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Wednesday, September 05, 2012 12:45 AM > To: Joachim Schmitz > Cc: git@vger.kernel.org; 'Johannes Sixt' > Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it > > "Joachim Schmitz&qu

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-04 Thread Junio C Hamano
"Joachim Schmitz" writes: >> From: Junio C Hamano [mailto:gits...@pobox.com] >> Sent: Tuesday, September 04, 2012 8:47 PM >> To: Joachim Schmitz >> Cc: git@vger.kernel.org; 'Johannes Sixt' >> Subject: Re: [PATCH 1/2] Support for setitimer() on

RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-04 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Tuesday, September 04, 2012 8:47 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org; 'Johannes Sixt' > Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it > > Junio C Hamano writes: &

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-04 Thread Johannes Sixt
Am 04.09.2012 19:23, schrieb Joachim Schmitz: >> From: Junio C Hamano [mailto:gits...@pobox.com] >> Only with the observation of "clone", I cannot tell if your timer is >> working. You can try repacking the test repository you created by >> your earlier "git clone" with "git repack -a -d -f" and s

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-04 Thread Junio C Hamano
Junio C Hamano writes: > "Joachim Schmitz" writes: > >>> Only with the observation of "clone", I cannot tell if your timer is >>> working. You can try repacking the test repository you created by >>> your earlier "git clone" with "git repack -a -d -f" and see what >>> happens. >> >> It does upd

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-04 Thread Junio C Hamano
"Joachim Schmitz" writes: >> Only with the observation of "clone", I cannot tell if your timer is >> working. You can try repacking the test repository you created by >> your earlier "git clone" with "git repack -a -d -f" and see what >> happens. > > It does update the counter too. Yeah, that w

RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-04 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Tuesday, September 04, 2012 6:58 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org; 'Johannes Sixt' > Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it > > "Joachim Schmitz"

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-04 Thread Junio C Hamano
"Joachim Schmitz" writes: >> If you cannot re-trigger the timer, then you will see "20%" shown >> after one second, silence for 4 seconds and then "done", for an >> operation that takes 5 seconds. Which is not the end of the world, >> though. It does not affect correctness. > > That does seem t

RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-03 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Monday, September 03, 2012 9:03 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org; 'Johannes Sixt' > Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it > > "Joachim Sch

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-03 Thread Junio C Hamano
"Joachim Schmitz" writes: >> >if (!value ) { >> >> Style: space before ')'? > > Will fix. > >> >errno = EFAULT; >> >return -1; >> >> EFAULT is good ;-) > > That's what 'man setitimer()' on Linux says to happen if invalid value is > found. > >> The emulation in m

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-03 Thread Junio C Hamano
Johannes Sixt writes: > Am 03.09.2012 11:31, schrieb Joachim Schmitz: >> >> Hmm, I see that there the errors are handled differently, like this: >> >> if (ovalue != NULL) >> return errno = EINVAL, >> error("setitimer param 3 != NULL not implemente

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-03 Thread Johannes Sixt
Am 03.09.2012 11:31, schrieb Joachim Schmitz: > > Hmm, I see that there the errors are handled differently, like this: > > if (ovalue != NULL) > return errno = EINVAL, > error("setitimer param 3 != NULL not implemented"); > > Should this be done in

RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-03 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Sunday, September 02, 2012 10:44 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org; Johannes Sixt > Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it > > "Joachim Schmitz" writ

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-02 Thread Junio C Hamano
"Joachim Schmitz" writes: >> > > Should we leave tv_usec untouched then? That was we round up on >> > > the next (and subsequent?) round(s). Or just set to ENOTSUP in >> > > setitimer if ovalue is !NULL? >> > >> > I was alluding to the latter. >> >> OK, will do that then. Thanks. >> Unless I s

RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-09-01 Thread Joachim Schmitz
> From: Joachim Schmitz [mailto:j...@schmitz-digital.de] > Sent: Thursday, August 30, 2012 7:23 PM > To: 'Junio C Hamano' > Cc: 'git@vger.kernel.org' > Subject: RE: [PATCH 1/2] Support for setitimer() on platforms lacking it > > > From: Junio C Hamano [

RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-08-30 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Thursday, August 30, 2012 7:14 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it > > "Joachim Schmitz" writes: > > >

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-08-30 Thread Junio C Hamano
"Joachim Schmitz" writes: >> I see no existing code calls setitimer() with non-NULL ovalue, and I >> do not think we would add a new caller that would do so in any time >> soon, so it may not be a bad idea to drop support of returning the >> remaining timer altogether from this emulation layer (j

RE: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-08-30 Thread Joachim Schmitz
> From: Junio C Hamano [mailto:gits...@pobox.com] > Sent: Tuesday, August 28, 2012 10:16 PM > To: Joachim Schmitz > Cc: git@vger.kernel.org > Subject: Re: [PATCH 1/2] Support for setitimer() on platforms lacking it > > "Joachim Schmitz" writes: > > > Impl

Re: [PATCH 1/2] Support for setitimer() on platforms lacking it

2012-08-28 Thread Junio C Hamano
"Joachim Schmitz" writes: > Implementation includes getitimer(), but for now it is static. > Supports ITIMER_REAL only. > > Signed-off-by: Joachim Schmitz > --- > May need a header file for ITIMER_*, struct itimerval and the prototypes, > But for now, and the HP NonStop platform this isn't neede