RE: [PATCH 6/7] test-hg.sh: help user correlate verbose output with email test
Richard Hansen wrote: It's hard to tell which author conversion test failed when the email addresses look similar. Signed-off-by: Richard Hansen rhan...@bbn.com --- contrib/remote-helpers/test-hg.sh | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh index 84c67ff..5eda265 100755 --- a/contrib/remote-helpers/test-hg.sh +++ b/contrib/remote-helpers/test-hg.sh @@ -209,16 +209,16 @@ test_expect_success 'authors' ' ../expected author_test alpha H G Wells we...@example.com - author_test beta test test unknown - author_test beta test t...@example.com (comment) test t...@example.com - author_test gamma t...@example.com Unknown t...@example.com - author_test delta namet...@example.com name t...@example.com - author_test epsilon name t...@example.com name t...@example.com - author_test zeta test test unknown - author_test eta test t...@example.com test t...@example.com - author_test theta test t...@example.com test t...@example.com - author_test iota test test at example dot com test unknown - author_test kappa t...@example.com Unknown t...@example.com + author_test beta beta beta unknown + author_test beta beta t...@example.com (comment) beta t...@example.com Two betas? + author_test gamma ga...@example.com Unknown ga...@example.com + author_test delta deltat...@example.com delta t...@example.com + author_test epsilon epsilon t...@example.com epsilon t...@example.com + author_test zeta zeta zeta unknown + author_test eta eta t...@example.com eta t...@example.com + author_test theta theta t...@example.com theta t...@example.com + author_test iota iota test at example dot com iota unknown + author_test kappa ka...@example.com Unknown ka...@example.com ) git clone hg::hgrepo gitrepo -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/7] test-hg.sh: help user correlate verbose output with email test
On 2013-11-11 06:42, Felipe Contreras wrote: Richard Hansen wrote: It's hard to tell which author conversion test failed when the email addresses look similar. Signed-off-by: Richard Hansen rhan...@bbn.com --- contrib/remote-helpers/test-hg.sh | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh index 84c67ff..5eda265 100755 --- a/contrib/remote-helpers/test-hg.sh +++ b/contrib/remote-helpers/test-hg.sh @@ -209,16 +209,16 @@ test_expect_success 'authors' ' ../expected author_test alpha H G Wells we...@example.com -author_test beta test test unknown -author_test beta test t...@example.com (comment) test t...@example.com Notice the two betas here in the original code. -author_test gamma t...@example.com Unknown t...@example.com -author_test delta namet...@example.com name t...@example.com -author_test epsilon name t...@example.com name t...@example.com -author_test zeta test test unknown -author_test eta test t...@example.com test t...@example.com -author_test theta test t...@example.com test t...@example.com -author_test iota test test at example dot com test unknown -author_test kappa t...@example.com Unknown t...@example.com +author_test beta beta beta unknown +author_test beta beta t...@example.com (comment) beta t...@example.com Two betas? See above. I can change them to beta1 and beta2, or if you'd prefer I can change them to beta and gamma and increment the subsequent entries. Thanks, Richard +author_test gamma ga...@example.com Unknown ga...@example.com +author_test delta deltat...@example.com delta t...@example.com +author_test epsilon epsilon t...@example.com epsilon t...@example.com +author_test zeta zeta zeta unknown +author_test eta eta t...@example.com eta t...@example.com +author_test theta theta t...@example.com theta t...@example.com +author_test iota iota test at example dot com iota unknown +author_test kappa ka...@example.com Unknown ka...@example.com ) git clone hg::hgrepo gitrepo -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/7] test-hg.sh: help user correlate verbose output with email test
On Mon, Nov 11, 2013 at 1:19 PM, Richard Hansen rhan...@bbn.com wrote: On 2013-11-11 06:42, Felipe Contreras wrote: Richard Hansen wrote: It's hard to tell which author conversion test failed when the email addresses look similar. Signed-off-by: Richard Hansen rhan...@bbn.com --- contrib/remote-helpers/test-hg.sh | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh index 84c67ff..5eda265 100755 --- a/contrib/remote-helpers/test-hg.sh +++ b/contrib/remote-helpers/test-hg.sh @@ -209,16 +209,16 @@ test_expect_success 'authors' ' ../expected author_test alpha H G Wells we...@example.com -author_test beta test test unknown -author_test beta test t...@example.com (comment) test t...@example.com Notice the two betas here in the original code. Ahh, that's a bug. -author_test gamma t...@example.com Unknown t...@example.com -author_test delta namet...@example.com name t...@example.com -author_test epsilon name t...@example.com name t...@example.com -author_test zeta test test unknown -author_test eta test t...@example.com test t...@example.com -author_test theta test t...@example.com test t...@example.com -author_test iota test test at example dot com test unknown -author_test kappa t...@example.com Unknown t...@example.com +author_test beta beta beta unknown +author_test beta beta t...@example.com (comment) beta t...@example.com Two betas? See above. I can change them to beta1 and beta2, or if you'd prefer I can change them to beta and gamma and increment the subsequent entries. Yeah, I would prefer that in two patches, one that fixes the sequence, and the other one that changes the emails. If you don't have time for that the original patch is OK by me. The problem with the sequence can be fixed later. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/7] test-hg.sh: help user correlate verbose output with email test
On 2013-11-11 14:29, Felipe Contreras wrote: On Mon, Nov 11, 2013 at 1:19 PM, Richard Hansen rhan...@bbn.com wrote: On 2013-11-11 06:42, Felipe Contreras wrote: Richard Hansen wrote: It's hard to tell which author conversion test failed when the email addresses look similar. Signed-off-by: Richard Hansen rhan...@bbn.com --- contrib/remote-helpers/test-hg.sh | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh index 84c67ff..5eda265 100755 --- a/contrib/remote-helpers/test-hg.sh +++ b/contrib/remote-helpers/test-hg.sh @@ -209,16 +209,16 @@ test_expect_success 'authors' ' ../expected author_test alpha H G Wells we...@example.com -author_test beta test test unknown -author_test beta test t...@example.com (comment) test t...@example.com Notice the two betas here in the original code. Ahh, that's a bug. -author_test gamma t...@example.com Unknown t...@example.com -author_test delta namet...@example.com name t...@example.com -author_test epsilon name t...@example.com name t...@example.com -author_test zeta test test unknown -author_test eta test t...@example.com test t...@example.com -author_test theta test t...@example.com test t...@example.com -author_test iota test test at example dot com test unknown -author_test kappa t...@example.com Unknown t...@example.com +author_test beta beta beta unknown +author_test beta beta t...@example.com (comment) beta t...@example.com Two betas? See above. I can change them to beta1 and beta2, or if you'd prefer I can change them to beta and gamma and increment the subsequent entries. Yeah, I would prefer that in two patches, one that fixes the sequence, and the other one that changes the emails. Will do. Thanks, Richard If you don't have time for that the original patch is OK by me. The problem with the sequence can be fixed later. Cheers. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
